From: "Kefu Chai" <k.chai@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH ceph reef-stable-8] bluefs: fix OSD crash caused by incorrect alignment assertion
Date: Thu, 15 Jan 2026 09:06:10 +0800 [thread overview]
Message-ID: <DFORD7JG763S.2T36JZ6VXJMIM@proxmox.com> (raw)
In-Reply-To: <176838078159.2016253.9744229034550295398.b4-ty@proxmox.com>
On Wed Jan 14, 2026 at 4:57 PM CST, Thomas Lamprecht wrote:
> On Wed, 07 Jan 2026 18:41:46 +0800, Kefu Chai wrote:
>> A regression was introduced in PR #62174 that added a `ceph_assert()`
>> statement which incorrectly assumes alloc_unit is always aligned. This
>> causes OSD crashes when the assertion fails.
>>
>> This cherry-pick removes the faulty assertion, resolving the crash while
>> maintaining correct functionality for both aligned and unaligned alloc_unit
>> values.
>>
>> [...]
>
> Applied, but ammended the commit to actually add the patch to the quilt series
> file, so that it's picked up by the debian build system and fixed the -22 lines
> offset of the diff hunk, thanks!
Thank you for taking care of this. Will double check the patches before
sending them out next time.
>
> btw. as the final reef release 18.2.8 is being planned (again), and should be
> ready soon after the ceph lab is up again after their DC move, do you think
> this should be released earlier or could it be fine to wait a bit.
Regarding the v18.2.8 release timeline: according to Patrick's email,
we're restarting QA for this final Reef release. It might take a couple
weeks to complete the QA process.
However, I'm concerned about the flapping OSD issue caused by the assert
failure -- it's a significant problem that we can't ignore. Given this,
do you think we should prioritize an earlier release to address it?
>
> FWIW, we could upload just the ceph-osd packages for now, or are there other
> daemons affected by this fix?
Yes, the only artifacts / executables using BlueFS are, ceph-osd,
ceph-bluestore-tool, ceph-objectstore-tool and ceph_objectstpre_bench.
All of them are currently provided by ceph-osd package. So it'd suffice
to upload the ceph-osd package for this hotfix.
>
> [1/1] bluefs: fix OSD crash caused by incorrect alignment assertion
> commit: 59bb899d8398575768b6ddd9dc7f4eabd0018533
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2026-01-15 1:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-07 10:41 [pve-devel] " Kefu Chai
2026-01-14 7:47 ` Kefu Chai
2026-01-14 8:57 ` [pve-devel] applied: " Thomas Lamprecht
2026-01-15 1:06 ` Kefu Chai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DFORD7JG763S.2T36JZ6VXJMIM@proxmox.com \
--to=k.chai@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox