From: "Michael Köppl" <m.koeppl@proxmox.com>
To: "Stoiko Ivanov" <s.ivanov@proxmox.com>,
"Michael Köppl" <m.koeppl@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH docs 1/1] firewall: set default value of NDP to 1 for nodes and guests
Date: Tue, 11 Nov 2025 10:42:33 +0100 [thread overview]
Message-ID: <DE5RN649UMBZ.3U54D20778IX6@proxmox.com> (raw)
In-Reply-To: <20251110195116.19a0b75a@rosa.proxmox.com>
Thanks, I overlooked that there is a gen script for this! Will send a
patch for pve-firewall instead.
On Mon Nov 10, 2025 at 7:51 PM CET, Stoiko Ivanov wrote:
> Thanks for noticing and providing the patch!
>
> parts of our documentation are generated based on the information we have
> in our JSONSchema and API calls (see e.g. gen-pve-firewall-host-opts.pl
> for a starting point)
>
> so the change would need to be done in the pve-firewall repo IIRC:
> https://git.proxmox.com/?p=pve-firewall.git;a=blob;f=src/PVE/Firewall.pm;h=ec9c9ae9c35ec31e7cd3ca28ac4b5c20fa7e8c39;hb=HEAD#l1404
>
>
> On Mon, 10 Nov 2025 18:11:24 +0100
> Michael Köppl <m.koeppl@proxmox.com> wrote:
>
>> The default value of 0 is wrong, since NDP is allowed by default for
>> both iptables and nftables. Update the documentation accordingly.
>>
>> Signed-off-by: Michael Köppl <m.koeppl@proxmox.com>
>> ---
>> pve-firewall-host-opts.adoc | 2 +-
>> pve-firewall-vm-opts.adoc | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/pve-firewall-host-opts.adoc b/pve-firewall-host-opts.adoc
>> index d561d0bf..e5770fbe 100644
>> --- a/pve-firewall-host-opts.adoc
>> +++ b/pve-firewall-host-opts.adoc
>> @@ -18,7 +18,7 @@ Log level for outgoing traffic.
>>
>> Enable logging of conntrack information.
>>
>> -`ndp`: `<boolean>` ('default =' `0`)::
>> +`ndp`: `<boolean>` ('default =' `1`)::
>>
>> Enable NDP (Neighbor Discovery Protocol).
>>
>> diff --git a/pve-firewall-vm-opts.adoc b/pve-firewall-vm-opts.adoc
>> index 9f191cf9..653ab4f4 100644
>> --- a/pve-firewall-vm-opts.adoc
>> +++ b/pve-firewall-vm-opts.adoc
>> @@ -22,7 +22,7 @@ Log level for outgoing traffic.
>>
>> Enable/disable MAC address filter.
>>
>> -`ndp`: `<boolean>` ('default =' `0`)::
>> +`ndp`: `<boolean>` ('default =' `1`)::
>>
>> Enable NDP (Neighbor Discovery Protocol).
>>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-11-11 9:42 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 17:11 Michael Köppl
2025-11-10 18:51 ` Stoiko Ivanov
2025-11-11 9:42 ` Michael Köppl [this message]
2025-11-11 10:27 ` Michael Köppl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DE5RN649UMBZ.3U54D20778IX6@proxmox.com \
--to=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.ivanov@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox