Re: [pve-devel] [PATCH-SERIES qemu/swtpm/storage/qemu-server/manager v2 00/16] fix #4693: drive: allow non-raw image formats for TPM state drive

["Daniel Kral" <d.kral@proxmox.com>]

On Mon Oct 20, 2025 at 4:12 PM CEST, Fiona Ebner wrote:
> Changes in v2:
> * Attempt unmounting left-over mounted files (thanks @Dano).
> * Add missing fuse dependencies for QEMU packaging (thanks @Dano).
> * Improve commit message for QMP peer abstraction (thanks @Dano).
> * Clean up files before starting new QSD instance.
> * Further abstract QMP peer in QMP client/monitor modules:
>   Replace 'vmid' by 'id' and allow specifying a peer name for error
>   messages. This is preparation for use cases of the storage daemon
>   where there might not be a single associated guest. For example,
>   restoring from a backup provider via exports of a storage daemon,
>   and a second storage daemon for the TPM of the VM itself.
> * Add UI patch.

I've tested the following (now mainly through the UI) again:

- creating a VM with tpmstate0 with raw/qcow2 format
- moving a VM with tpmstate0 with qcow2 format between storages
- converting existing VM from raw to qcow2 format and vice versa
- cloning VMs to the same storage again
- starting any of those (debian13 and win11) worked fine
- `kill -KILL $(pidof qemu-storage-daemon)` and starting the VM again
  afterwards cleaned up as expected

I've checked the commits without R-b and diffed the new code changes
against the v1 and grepped for changes from vmid to id and whether all
*_cmd(...) calls have the right arguments with the new name field.

Looks good to me, consider this:

Reviewed-by: Daniel Kral <d.kral@proxmox.com>
Tested-by: Daniel Kral <d.kral@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel