public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
* [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property
@ 2025-11-06  8:54 Nicolas Frey
  2025-11-06  9:13 ` Lukas Wagner
  2025-11-06 17:52 ` [pve-devel] applied: " Thomas Lamprecht
  0 siblings, 2 replies; 3+ messages in thread
From: Nicolas Frey @ 2025-11-06  8:54 UTC (permalink / raw)
  To: pve-devel

The `all` architecture is defined for e.g. all proxmox perl packages,
so add it to the enum.

This would lead to an error in the update view in PDM:
[...] failed to parse api response: unknown variant `all` [...]

Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
---
 PVE/API2/APT.pm | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index 1ccbaf97..395ce070 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -204,7 +204,7 @@ my $apt_package_return_props = {
     Arch => {
         type => 'string',
         description => 'Package Architecture.',
-        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
+        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
     },
     Description => {
         type => 'string',
-- 
2.47.3


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property
  2025-11-06  8:54 [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property Nicolas Frey
@ 2025-11-06  9:13 ` Lukas Wagner
  2025-11-06 17:52 ` [pve-devel] applied: " Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Lukas Wagner @ 2025-11-06  9:13 UTC (permalink / raw)
  To: Proxmox VE development discussion, Nicolas Frey

On Thu Nov 6, 2025 at 9:54 AM CET, Nicolas Frey wrote:
> The `all` architecture is defined for e.g. all proxmox perl packages,
> so add it to the enum.
>
> This would lead to an error in the update view in PDM:
> [...] failed to parse api response: unknown variant `all` [...]
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Nicolas Frey <n.frey@proxmox.com>
> ---
>  PVE/API2/APT.pm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
> index 1ccbaf97..395ce070 100644
> --- a/PVE/API2/APT.pm
> +++ b/PVE/API2/APT.pm
> @@ -204,7 +204,7 @@ my $apt_package_return_props = {
>      Arch => {
>          type => 'string',
>          description => 'Package Architecture.',
> -        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x)],
> +        enum => [qw(armhf arm64 amd64 ppc64el risc64 s390x all)],
>      },
>      Description => {
>          type => 'string',

Looks good to me, thanks for the fix!

Reviewed-by: Lukas Wagner <l.wagner@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

* [pve-devel] applied: [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property
  2025-11-06  8:54 [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property Nicolas Frey
  2025-11-06  9:13 ` Lukas Wagner
@ 2025-11-06 17:52 ` Thomas Lamprecht
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Lamprecht @ 2025-11-06 17:52 UTC (permalink / raw)
  To: pve-devel, Nicolas Frey

On Thu, 06 Nov 2025 09:54:23 +0100, Nicolas Frey wrote:
> The `all` architecture is defined for e.g. all proxmox perl packages,
> so add it to the enum.
> 
> This would lead to an error in the update view in PDM:
> [...] failed to parse api response: unknown variant `all` [...]
> 
> 
> [...]

Applied, thanks!

[1/1] api: apt: add 'all' option to Arch property
      commit: 162cba11e794a3c3a09cf2ece1feff88804a5806


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-11-06 17:52 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-11-06  8:54 [pve-devel] [PATCH pve-manager 1/1] api: apt: add 'all' option to Arch property Nicolas Frey
2025-11-06  9:13 ` Lukas Wagner
2025-11-06 17:52 ` [pve-devel] applied: " Thomas Lamprecht

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal