From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Maximiliano Sandoval" <m.sandoval@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager 1/2] add context to translatable strings
Date: Fri, 24 Oct 2025 12:50:58 +0200 [thread overview]
Message-ID: <DDQHTR3WAT0V.2JJY9CMZLIZ8I@proxmox.com> (raw)
In-Reply-To: <20251023083054.116763-1-m.sandoval@proxmox.com>
On Thu Oct 23, 2025 at 10:30 AM CEST, Maximiliano Sandoval wrote:
> These will be displayed in translator editors and provide context for
> translators.
>
> Some strings like "Verify State" are not clear in meaning without added
> context. It is a reasonable assumption for "Verify" to be a verb, since
> button labels should start with a verb and we do not have enough context
> in the i18n context to see this is not part of such a label, but in this
> case we actually mean the state of the verification task.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
-->8 snip 8<--
both patches here look good to me so consider this:
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-10-24 10:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-23 8:30 Maximiliano Sandoval
2025-10-23 8:30 ` [pve-devel] [PATCH manager 2/2] improve some " Maximiliano Sandoval
2025-10-24 10:50 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDQHTR3WAT0V.2JJY9CMZLIZ8I@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=m.sandoval@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox