Re: [pve-devel] [PATCH installer 06/14] common: implement support for `network_interface_pin_map` config

["Michael Köppl" <m.koeppl@proxmox.com>]

1 comment inline

On Tue Oct 14, 2025 at 3:21 PM CEST, Christoph Heiss wrote:
> Adds all the pieces for installer frontends to wire up pinning support,
> i.e. deserializing from the runtime environment, doing verification and
> serializing it out to the low-level installer.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
>  proxmox-auto-installer/src/utils.rs     |   3 +-
>  proxmox-installer-common/src/lib.rs     |   5 +
>  proxmox-installer-common/src/options.rs | 158 ++++++++++++++++++++++--
>  proxmox-installer-common/src/setup.rs   |  51 +++++++-
>  proxmox-tui-installer/src/setup.rs      |   3 +-
>  5 files changed, 203 insertions(+), 17 deletions(-)
>
> diff --git a/proxmox-auto-installer/src/utils.rs b/proxmox-auto-installer/src/utils.rs
> index 7d42f2c..eb666d1 100644
> --- a/proxmox-auto-installer/src/utils.rs
> +++ b/proxmox-auto-installer/src/utils.rs
> @@ -2,7 +2,7 @@ use anyhow::{Context, Result, bail};
>  use glob::Pattern;
>  use log::info;
>  use std::{
> -    collections::{BTreeMap, HashSet},
> +    collections::{BTreeMap, HashMap, HashSet},
>      process::Command,
>  };
>  
> @@ -485,6 +485,7 @@ pub fn parse_answer(
>          root_ssh_keys: answer.global.root_ssh_keys.clone(),
>  
>          mngmt_nic: network_settings.ifname,
> +        network_interface_pin_map: HashMap::new(),
>  
>          hostname: network_settings
>              .fqdn
> diff --git a/proxmox-installer-common/src/lib.rs b/proxmox-installer-common/src/lib.rs
> index ea907a0..a85d5f8 100644
> --- a/proxmox-installer-common/src/lib.rs
> +++ b/proxmox-installer-common/src/lib.rs
> @@ -10,6 +10,11 @@ pub mod http;
>  #[cfg(feature = "cli")]
>  pub mod cli;
>  
> +pub mod net {
> +    /// Maximum length of the (primary) name of a network interface
> +    pub const MAX_IFNAME_LEN: usize = 15; // IFNAMSIZ - 1 to account for NUL byte
> +}
> +
>  pub const RUNTIME_DIR: &str = "/run/proxmox-installer";
>  
>  /// Default placeholder value for the administrator email address.
> diff --git a/proxmox-installer-common/src/options.rs b/proxmox-installer-common/src/options.rs
> index 59e8560..60ea227 100644
> --- a/proxmox-installer-common/src/options.rs
> +++ b/proxmox-installer-common/src/options.rs
> @@ -1,12 +1,14 @@
>  use anyhow::{Result, bail};
>  use regex::Regex;
>  use serde::{Deserialize, Serialize};
> +use std::collections::HashMap;
>  use std::net::{IpAddr, Ipv4Addr};
>  use std::str::FromStr;
>  use std::sync::OnceLock;
>  use std::{cmp, fmt};
>  
>  use crate::disk_checks::check_raid_min_disks;
> +use crate::net::MAX_IFNAME_LEN;
>  use crate::setup::{LocaleInfo, NetworkInfo, RuntimeInfo, SetupInfo};
>  use crate::utils::{CidrAddress, Fqdn};
>  
> @@ -476,6 +478,54 @@ impl TimezoneOptions {
>      }
>  }
>  
> +/// Options controlling the behaviour of the network interface pinning (by
> +/// creating appropriate systemd.link files) during the installation.
> +#[derive(Clone, Debug, Default, PartialEq, Deserialize)]
> +#[serde(rename_all = "kebab-case", deny_unknown_fields)]
> +pub struct NetworkInterfacePinningOptions {
> +    /// Maps MAC address to custom name
> +    #[serde(default)]
> +    pub mapping: HashMap<String, String>,
> +}
> +
> +impl NetworkInterfacePinningOptions {
> +    /// Default prefix to prepend to the pinned interface ID as received from the low-level
> +    /// installer.
> +    pub const DEFAULT_PREFIX: &str = "nic";
> +
> +    /// Do some basic checks on the options.
> +    ///
> +    /// This checks for:
> +    /// - empty interface names
> +    /// - overlong interface names
> +    /// - duplicate interface names

imo it would make sense to additionally also have the check that the
interface name is not fully numeric, since according to the docs, this
is not allowed [0].

[0] https://manpages.debian.org/testing/udev/systemd.link.5.en.html#%5BLINK%5D_SECTION_OPTIONS



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel