From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager v2 10/18] compile ha rules to a more compact representation
Date: Mon, 13 Oct 2025 09:50:42 +0200 [thread overview]
Message-ID: <DDH13Q5VDOY9.FPSQYN5LE5XA@proxmox.com> (raw)
In-Reply-To: <20250909083539.39675-11-d.kral@proxmox.com>
On Tue Sep 9, 2025 at 10:33 AM CEST, Daniel Kral wrote:
> -=head3 get_node_affinity($rules, $sid, $online_node_usage)
> +=head3 get_node_affinity($node_affinity, $sid, $online_node_usage)
Just noticed that I forgot to change $online_node_usage to $online_nodes
here..
>
> Returns a list of two hashes representing the node affinity of C<$sid>
> -according to the node affinity rules in C<$rules> and the available nodes in
> +according to the node affinity C<$node_affinity> and the available nodes in
> the C<$online_nodes> hash.
>
> The first hash is a hash set of available nodes, i.e. nodes where the
> @@ -251,31 +265,15 @@ If there are no available nodes at all, returns C<undef>.
>
> =cut
>
> -sub get_node_affinity : prototype($$$) {
> - my ($rules, $sid, $online_nodes) = @_;
> +sub get_node_affinity {
> + my ($node_affinity, $sid, $online_nodes) = @_;
>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-13 7:50 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-09 8:33 [pve-devel] [PATCH ha-manager v2 00/18] HA rules fixes + cleanup + performance improvements Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 01/18] config: do not add ignored resources to dependent resources Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 02/18] manager: retranslate rules if nodes are added or removed Daniel Kral
2025-09-11 15:01 ` Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 03/18] rules: factor out disjoint rules' resource set helper Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 04/18] rules: resource affinity: inter-consistency check with merged positive rules Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 05/18] rules: add merged positive resource affinity info in global checks Daniel Kral
2025-09-10 17:35 ` Thomas Lamprecht
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 06/18] rules: make rules sorting optional in foreach_rule helper Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 07/18] rename rule's canonicalize stage to transform stage Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 08/18] rules: make plugins register transformers instead of plugin_transform Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 09/18] rules: node affinity: decouple get_node_affinity helper from Usage class Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 10/18] compile ha rules to a more compact representation Daniel Kral
2025-10-13 7:50 ` Daniel Kral [this message]
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 11/18] test: rules: use to_json instead of Data::Dumper for config output Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 12/18] test: rules: add compiled config output to rules config test cases Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 13/18] rules: node affinity: define node priority outside hash access Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 14/18] move minimum version check helper to ha tools Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 15/18] manager: move group migration cooldown variable into helper Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 16/18] api: status: sync active service counting with lrm's helper Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 17/18] manager: group migration: " Daniel Kral
2025-09-09 8:33 ` [pve-devel] [PATCH ha-manager v2 18/18] factor out counting of active services into helper Daniel Kral
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDH13Q5VDOY9.FPSQYN5LE5XA@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox