From: "Max R. Carrara" <m.carrara@proxmox.com>
To: "Lorne Guse" <boomshankerx@hotmail.com>,
"Morgan Littlewood" <morgan@truenas.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] TrueNAS over iSCSI: Snapshot Management
Date: Mon, 06 Oct 2025 15:17:26 +0200 [thread overview]
Message-ID: <DDB9O2XSSOP9.3I8N8PYCCJWXE@proxmox.com> (raw)
In-Reply-To: <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com>
On Mon Oct 6, 2025 at 3:09 AM CEST, Lorne Guse wrote:
> [...]
Hi Lorne, hi Morgan!
Sorry—only now finally got some time to look into this.
Regarding multi-generational snapshot rollbacks: That is something
that's possible actually; our `lvm-thin` storage supports that, for
example [0]. You're probably running into the default implementation [1],
hence the error.
We don't support it for our ZFS pool storage though [2] (and thus also
not for the ZFS over iSCSI storages), since `zfs rollback` doesn't
support it without destroying intermediate snapshots [3].
The user can still do rollbacks on older snapshots, they just have to
delete the intermediate ones first, in this case. (So basically what
`zfs rollback` requires one to do.)
With all that being said, I agree with Morgan here; it's best to just
let PVE manage the snapshots and whatever contents are on the volume, as
it is a cleaner experience for the user. (Principle of least surprise
and all that.)
Hope that helps! If you need anything else, feel free to ping me! (:
[0]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/LvmThinPlugin.pm;h=ccefd0eb24630a4ae5e206002760126dfce9304a;hb=refs/heads/master#l366
[1]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/Plugin.pm;h=2291d72d929b9de83f7703aae146372e4b663860;hb=refs/heads/master#l1325
[2]: https://git.proxmox.com/?p=pve-storage.git;a=blob;f=src/PVE/Storage/ZFSPoolPlugin.pm;h=3b3456b7482ad4388a757e80484412384a677da1;hb=refs/heads/master#l551
[3]: https://openzfs.github.io/openzfs-docs/man/master/8/zfs-rollback.8.html
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-06 13:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <DM6PR17MB34662F5ABDA587979C0FFDA2D019A@DM6PR17MB3466.namprd17.prod.outlook.com>
2025-10-05 4:11 ` Lorne Guse via pve-devel
[not found] ` <DM6PR17MB346659F576D1D081C71CCC6DD0E2A@DM6PR17MB3466.namprd17.prod.outlook.com>
2025-10-05 22:02 ` Morgan Littlewood via pve-devel
[not found] ` <CABr3vq+8FF-T0NC=aTXq6ke_PgSYjJhbo0Pk4BPT64vRHbMC+w@mail.gmail.com>
2025-10-06 1:09 ` Lorne Guse via pve-devel
[not found] ` <DM6PR17MB3466C924D9FC9565703D5B64D0E3A@DM6PR17MB3466.namprd17.prod.outlook.com>
2025-10-06 13:17 ` Max R. Carrara [this message]
2025-10-06 19:59 ` Morgan Littlewood via pve-devel
2025-09-27 16:45 Lorne Guse via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DDB9O2XSSOP9.3I8N8PYCCJWXE@proxmox.com \
--to=m.carrara@proxmox.com \
--cc=boomshankerx@hotmail.com \
--cc=morgan@truenas.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox