From: "Daniel Kral" <d.kral@proxmox.com>
To: "Fiona Ebner" <f.ebner@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: pve-devel <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH ha-manager 1/1] api: relocate/migrate resource: improve initialization of variables to avoid Perl warning
Date: Fri, 03 Oct 2025 09:47:51 +0200 [thread overview]
Message-ID: <DD8IS3P27XX0.1RNMDOT8X93P2@proxmox.com> (raw)
In-Reply-To: <5e2e3770-80ad-4470-abdc-9ff99a4234d3@proxmox.com>
On Thu Oct 2, 2025 at 3:39 PM CEST, Fiona Ebner wrote:
> Am 02.10.25 um 2:18 PM schrieb Daniel Kral:
>> On Wed Oct 1, 2025 at 4:02 PM CEST, Fiona Ebner wrote:
>>> diff --git a/src/PVE/HA/Config.pm b/src/PVE/HA/Config.pm
>>> index 301c62f..b52465f 100644
>>> --- a/src/PVE/HA/Config.pm
>>> +++ b/src/PVE/HA/Config.pm
>>> @@ -397,6 +397,7 @@ sub get_resource_motion_info {
>>> push @$dependent_resources, $_ for sort keys %$together;
>>>
>>> for my $node (keys %$ns) {
>>> + $blocking_resources_by_node->{$node} = [];
>>
>> Unfortunately this breaks some callers of get_resource_motion_info(...),
>> which assume that a set $blocking_resources_by_node->{$node} means that
>> there was some blocking HA resource on that node, e.g.
>>
>> $ ha-manager crm-command migrate vm:10000 node2
>> cannot migrate resource 'vm:10000' to node 'node2':
>
> Are you sure this is with the first part of my patch included? It works
> for me.
>
My bad, I'm sorry, you're right!
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-10-03 7:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-10-01 14:02 [pve-devel] [PATCH ha-manager 0/1] " Fiona Ebner
2025-10-01 14:02 ` [pve-devel] [PATCH ha-manager 1/1] " Fiona Ebner
2025-10-01 14:06 ` Fiona Ebner
2025-10-02 12:18 ` Daniel Kral
2025-10-02 13:39 ` Fiona Ebner
2025-10-03 7:47 ` Daniel Kral [this message]
2025-10-02 13:51 ` [pve-devel] superseded: [PATCH ha-manager 0/1] " Fiona Ebner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD8IS3P27XX0.1RNMDOT8X93P2@proxmox.com \
--to=d.kral@proxmox.com \
--cc=f.ebner@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox