public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend 4/4] chore: add upper bound flutter constraint and update dart sdk constraint
Date: Mon, 29 Sep 2025 09:58:37 +0200	[thread overview]
Message-ID: <DD54I64M70DG.1HT5YH6NPIEL1@proxmox.com> (raw)
In-Reply-To: <a681abde-a9ff-4193-8b6c-8a4255cc5a4c@proxmox.com>

Thanks @Dominik, Makes sense. I will update it accordingly and will send
another patch.

On Fri Sep 26, 2025 at 11:25 AM CEST, Dominik Csapak wrote:
>
>
> On 9/24/25 12:37 PM, Shan Shaji wrote:
>> Starting form language version 3.9, the flutter constrain upper bound is
>> now respected in the root package. Setting the flutter constraint can be
>> usefull to ensure everyone will use the same SDK.
>> 
>> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
>> ---
>>   pubspec.lock | 2 +-
>>   pubspec.yaml | 3 ++-
>>   2 files changed, 3 insertions(+), 2 deletions(-)
>> 
>> diff --git a/pubspec.lock b/pubspec.lock
>> index 862241e..4f51e63 100644
>> --- a/pubspec.lock
>> +++ b/pubspec.lock
>> @@ -909,4 +909,4 @@ packages:
>>       version: "3.1.3"
>>   sdks:
>>     dart: ">=3.9.0 <4.0.0"
>> -  flutter: ">=3.35.0"
>> +  flutter: "3.35.0"
>> diff --git a/pubspec.yaml b/pubspec.yaml
>> index a4d5b69..e447377 100644
>> --- a/pubspec.yaml
>> +++ b/pubspec.yaml
>> @@ -15,7 +15,8 @@ publish_to: none
>>   version: 1.8.1+46
>>   
>>   environment:
>> -  sdk: '>=3.0.0 <4.0.0'
>> +  sdk: '>=3.9.0 <4.0.0'
>> +  flutter: 3.35.0
>>   
>
> not sure if we want to make it that hard of a requirement
> maybe having
>
> flutter: '>=3.35.0 <3.36.0'
>
> would be better ?
>
> then we don't have to update this on every minor patch version?
>
>>   dependencies:
>>     flutter:



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-09-29  7:58 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-09-24 10:36 [pve-devel] [PATCH pve_flutter_frontend 0/4] fix: add fix for dart-analyze issues and replace deprecated APIs Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 1/4] fix: run `dart fix` to fix the problems identified by diagnostic Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 2/4] cleanup: dart-analyze: add explicit type annotation Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 3/4] fix: dart-analyze: remove deprecated props and use `RadioGroup` Shan Shaji
2025-09-24 10:36 ` [pve-devel] [PATCH pve_flutter_frontend 4/4] chore: add upper bound flutter constraint and update dart sdk constraint Shan Shaji
2025-09-26  9:25   ` Dominik Csapak
2025-09-29  7:58     ` Shan Shaji [this message]
2025-09-29  9:17   ` Shan Shaji
2025-09-26  9:25 ` [pve-devel] partially applied: [PATCH pve_flutter_frontend 0/4] fix: add fix for dart-analyze issues and replace deprecated APIs Dominik Csapak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DD54I64M70DG.1HT5YH6NPIEL1@proxmox.com \
    --to=s.shaji@proxmox.com \
    --cc=d.csapak@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal