From: "Daniel Kral" <d.kral@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH container/docs/ha-manager/manager/proxmox-widget-toolkit/qemu-server v2 0/8] fix #6613: update HA rules upon resource deletion
Date: Fri, 26 Sep 2025 16:23:00 +0200 [thread overview]
Message-ID: <DD2SSU6XZQTW.27BNQ20YL4GCE@proxmox.com> (raw)
In-Reply-To: <20250924160747.430018-1-m.koeppl@proxmox.com>
On Wed Sep 24, 2025 at 6:07 PM CEST, Michael Köppl wrote:
> This patch series aims to fix #6613 [0]. Although an implementation was
> proposed in the past, it was not applied since it was unclear how to
> handle the case where the removed resource is the last resource in a
> rule.
Hi!
I left one inline note for the ConfirmRemoveDialog.. I'm not sure if we
should change all other usages for the special case, but as I said, it
might just be nit-picking from my end.
We could also just go for a light-weight yes/no confirm dialog without
replacing the users of Proxmox.window.SafeDestroy but only make the HA
resource delete button the only user of ConfirmRemoveDialog.
Otherwise, it looks good and works as expected. With the inline note /
above addressed, consider this as:
Tested-by: Daniel Kral <d.kral@proxmox.com>
Reviewed-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-26 14:23 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-09-24 16:07 Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH ha-manager v2 1/2] fix #6613: update rules containing the resource to be deleted Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH ha-manager v2 2/2] api: add purge parameter for resource deletion Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH qemu-server v2 1/1] fix #6613: pass purge param to delete_service_from_config Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH container " Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH widget-toolkit v2 1/1] window: add ConfirmRemoveDialog Michael Köppl
2025-09-26 14:15 ` Daniel Kral
2025-09-24 16:07 ` [pve-devel] [PATCH manager v2 1/2] ui: add ConfirmRemoveResource window Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH manager v2 2/2] ui: use ConfirmRemoveResource window for removing resources Michael Köppl
2025-09-24 16:07 ` [pve-devel] [PATCH docs v2 1/1] add notes about effects of purge flag for resource and guest removal Michael Köppl
2025-09-26 14:23 ` Daniel Kral [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DD2SSU6XZQTW.27BNQ20YL4GCE@proxmox.com \
--to=d.kral@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox