[pve-devel] [PATCH manager] ui: fix datacenter notes toolbar visibility

[pve-devel] [PATCH manager] ui: fix datacenter notes toolbar visibility

[Dominik Csapak]

the recent commit
 d2660fc7 (ui: resource tree: improve performance on initial update)
changed how we construct the resource tree, namely outside the
treestore. While it worked fine mostly, the standard
`Ext.data.TreeModel` was used. This lead to problem with the detection
of some things, since we expected all properties that were defined on
the custom `PVETree` model.

To fix this, create an instance of `PVETree` instead.
Note that this might also fix other things that depend on the
PVETree specific properties on the datacenter root node.

Fixes: d2660fc7 (ui: resource tree: improve performance on initial update)
Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
---
this should probably also be backported to stable-bookworm

 www/manager6/tree/ResourceTree.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
index 7a8d00c0..315976e0 100644
--- a/www/manager6/tree/ResourceTree.js
+++ b/www/manager6/tree/ResourceTree.js
@@ -339,7 +339,7 @@ Ext.define('PVE.tree.ResourceTree', {
 
             let rootnode;
             if (firstUpdate) {
-                rootnode = Ext.create('Ext.data.TreeModel', {
+                rootnode = Ext.create('PVETree', {
                     expanded: true,
                     id: 'root',
                     text: gettext('Datacenter'),
-- 
2.47.3



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager] ui: fix datacenter notes toolbar visibility

[Michael Köppl]

Since I was just now encountering this problem, gave this a quick spin.
Works as advertised, did not notice anything off.

Tested-by: Michael Köppl <m.koeppl@proxmox.com>

On Fri Sep 12, 2025 at 1:32 PM CEST, Dominik Csapak wrote:
> the recent commit
>  d2660fc7 (ui: resource tree: improve performance on initial update)
> changed how we construct the resource tree, namely outside the
> treestore. While it worked fine mostly, the standard
> `Ext.data.TreeModel` was used. This lead to problem with the detection
> of some things, since we expected all properties that were defined on
> the custom `PVETree` model.
>
> To fix this, create an instance of `PVETree` instead.
> Note that this might also fix other things that depend on the
> PVETree specific properties on the datacenter root node.
>
> Fixes: d2660fc7 (ui: resource tree: improve performance on initial update)
> Signed-off-by: Dominik Csapak <d.csapak@proxmox.com>
> ---
> this should probably also be backported to stable-bookworm
>
>  www/manager6/tree/ResourceTree.js | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/www/manager6/tree/ResourceTree.js b/www/manager6/tree/ResourceTree.js
> index 7a8d00c0..315976e0 100644
> --- a/www/manager6/tree/ResourceTree.js
> +++ b/www/manager6/tree/ResourceTree.js
> @@ -339,7 +339,7 @@ Ext.define('PVE.tree.ResourceTree', {
>  
>              let rootnode;
>              if (firstUpdate) {
> -                rootnode = Ext.create('Ext.data.TreeModel', {
> +                rootnode = Ext.create('PVETree', {
>                      expanded: true,
>                      id: 'root',
>                      text: gettext('Datacenter'),



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH manager] ui: fix datacenter notes toolbar visibility

[Thomas Lamprecht]

On Fri, 12 Sep 2025 13:32:22 +0200, Dominik Csapak wrote:
> the recent commit
>  d2660fc7 (ui: resource tree: improve performance on initial update)
> changed how we construct the resource tree, namely outside the
> treestore. While it worked fine mostly, the standard
> `Ext.data.TreeModel` was used. This lead to problem with the detection
> of some things, since we expected all properties that were defined on
> the custom `PVETree` model.
> 
> [...]

Applied to master and stable-8, thanks!

[1/1] ui: fix datacenter notes toolbar visibility
      commit: dbc0ca81d68bc8114d18dd3edd0ac4bb1ca8cac6


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel