* [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog
@ 2025-09-02 14:53 Maximiliano Sandoval
2025-09-02 15:06 ` Daniel Kral
0 siblings, 1 reply; 2+ messages in thread
From: Maximiliano Sandoval @ 2025-09-02 14:53 UTC (permalink / raw)
To: pve-devel; +Cc: Lukas Wagner
This was displayed wrongly on the web UI and when calling
pvesh get /nodes/localhost/apt/changelog
One potential example of such a package was bind9-dnsutils where the
character `ř` was rendered as `Å`.
Reported-by: Lukas Wagner <l.wagner@proxmox.com>
Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
PVE/API2/APT.pm | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/PVE/API2/APT.pm b/PVE/API2/APT.pm
index bd651ba1..4de4cb5b 100644
--- a/PVE/API2/APT.pm
+++ b/PVE/API2/APT.pm
@@ -7,6 +7,7 @@ use POSIX;
use File::stat ();
use IO::File;
use File::Basename;
+use Encode qw(decode);
use LWP::UserAgent;
@@ -418,7 +419,7 @@ __PACKAGE__->register_method({
timeout => 10,
logfunc => sub {
my $line = shift;
- $output .= "$line\n";
+ $output .= decode('UTF-8', $line) . "\n";
},
noerr => 1,
);
--
2.47.2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog
2025-09-02 14:53 [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog Maximiliano Sandoval
@ 2025-09-02 15:06 ` Daniel Kral
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Kral @ 2025-09-02 15:06 UTC (permalink / raw)
To: Proxmox VE development discussion; +Cc: pve-devel, Lukas Wagner
On Tue Sep 2, 2025 at 4:53 PM CEST, Maximiliano Sandoval wrote:
> This was displayed wrongly on the web UI and when calling
>
> pvesh get /nodes/localhost/apt/changelog
>
> One potential example of such a package was bind9-dnsutils where the
> character `ř` was rendered as `Å`.
>
> Reported-by: Lukas Wagner <l.wagner@proxmox.com>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
Tested this with a few packages (apt, bind9-dnsutils, dpkg) which had
non-ASCII characters and it correctly output them with the pvesh command
above after applying.
Tested-by: Daniel Kral <d.kral@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-09-02 15:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-09-02 14:53 [pve-devel] [PATCH manager] api: apt: Return valid utf8 on changelog Maximiliano Sandoval
2025-09-02 15:06 ` Daniel Kral
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox