Re: [pve-devel] [PATCH qemu-server v2 4/6] log when issuing a guest-fsfreeze command

["Daniel Kral" <d.kral@proxmox.com>]

On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote:
>  These messages appear during replication or snapshots.

nit: would be nice to also document that moving the logging from
PVE::Replication::replicate(...) here now makes the messages appear
at all call sites of __snapshot_freeze(...).

The commit messages indicated to me that it has already been that way
before.

>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/QemuConfig.pm | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/src/PVE/QemuConfig.pm b/src/PVE/QemuConfig.pm
> index 51593b60..679c3893 100644
> --- a/src/PVE/QemuConfig.pm
> +++ b/src/PVE/QemuConfig.pm
> @@ -310,9 +310,11 @@ sub __snapshot_freeze {
>      my ($class, $vmid, $unfreeze) = @_;
>  
>      if ($unfreeze) {
> +        print "issuing guest agent 'guest-fsfreeze-thaw' command\n";
>          eval { mon_cmd($vmid, "guest-fsfreeze-thaw"); };
>          warn "guest-fsfreeze-thaw problems - $@" if $@;
>      } else {
> +        print "issuing guest agent 'guest-fsfreeze-freeze' command\n";
>          eval { mon_cmd($vmid, "guest-fsfreeze-freeze"); };
>          warn "guest-fsfreeze-freeze problems - $@" if $@;
>      }



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel