Re: [pve-devel] [PATCH qemu-server v2 6/6] deprecate freeze-fs-on-backup qga setting

["Daniel Kral" <d.kral@proxmox.com>]

On Tue Sep 2, 2025 at 2:45 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/PVE/QemuServer.pm | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/src/PVE/QemuServer.pm b/src/PVE/QemuServer.pm
> index cdd44eb0..b8416b4c 100644
> --- a/src/PVE/QemuServer.pm
> +++ b/src/PVE/QemuServer.pm
> @@ -161,8 +161,10 @@ my $agent_fmt = {
>          optional => 1,
>          default => 0,
>      },
> +    # TODO Remove in Proxmox VE 10
>      'freeze-fs-on-backup' => {
> -        description => "Freeze/thaw guest filesystems on backup for consistency.",
> +        description => "Freeze/thaw guest filesystems on backup for consistency.\n\n"
> +            . "Deprecated: Use 'guest-fsfreeze' instead",

nit: end the deprecation notice with a full-stop

also seems like we put the deprecation notice at the start instead of
the end, at least what I found with a quick grep over all PVE repos
(exception: qm's bootdisk):

    Deprecated: Use 'guest-fsfreeze' instead. Freeze/thaw guest
    filesystems on backup for consistency.

>          type => 'boolean',
>          optional => 1,
>          default => 1,



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel