[pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary

[pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary

[Maximiliano Sandoval]

This change ensures that the storage unites are displayed consistently
between the graph and the usage label right above.

When setting the unit to `bytes` the graph will now, for example, show
"130 GB" instead of "130 G", which matches the usage displayed above and
removes any ambiguity about whether "G" refers to GiB or GB.

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---

Differences from v1:

 - Use lowercase in commit name
 - Add a second commit changing the renderer of the bytes_used


 www/manager6/storage/Summary.js | 1 +
 1 file changed, 1 insertion(+)

diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js
index 8809603b..b263cb87 100644
--- a/www/manager6/storage/Summary.js
+++ b/www/manager6/storage/Summary.js
@@ -52,6 +52,7 @@ Ext.define('PVE.storage.Summary', {
                     fields: ['total', 'used'],
                     fieldTitles: ['Total Size', 'Used Size'],
                     store: rrdstore,
+                    unit: 'bytes',
                 },
             ],
             listeners: {
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] [PATCH manager v2 2/2] api: ceph: set bytes_used's renderer to bytes

[Maximiliano Sandoval]

This will make pveceph pool ls report the 'Used' column specifying its
units:

$ pveceph pool ls --noborder
... Used
... 2.07 MiB
... 108.61 KiB

Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
---
 PVE/API2/Ceph/Pool.pm | 1 +
 1 file changed, 1 insertion(+)

diff --git a/PVE/API2/Ceph/Pool.pm b/PVE/API2/Ceph/Pool.pm
index 4df6f2ca..73166cdf 100644
--- a/PVE/API2/Ceph/Pool.pm
+++ b/PVE/API2/Ceph/Pool.pm
@@ -108,6 +108,7 @@ __PACKAGE__->register_method({
                 bytes_used => {
                     type => 'integer',
                     title => 'Used',
+                    renderer => 'bytes',
                 },
                 target_size => {
                     type => 'integer',
-- 
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary

[Shannon Sterz]

On Fri Aug 29, 2025 at 11:43 AM CEST, Maximiliano Sandoval wrote:
> This change ensures that the storage unites are displayed consistently
> between the graph and the usage label right above.
>
> When setting the unit to `bytes` the graph will now, for example, show
> "130 GB" instead of "130 G", which matches the usage displayed above and
> removes any ambiguity about whether "G" refers to GiB or GB.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Differences from v1:
>
>  - Use lowercase in commit name
>  - Add a second commit changing the renderer of the bytes_used
>
>
>  www/manager6/storage/Summary.js | 1 +
>  1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js
> index 8809603b..b263cb87 100644
> --- a/www/manager6/storage/Summary.js
> +++ b/www/manager6/storage/Summary.js
> @@ -52,6 +52,7 @@ Ext.define('PVE.storage.Summary', {
>                      fields: ['total', 'used'],
>                      fieldTitles: ['Total Size', 'Used Size'],
>                      store: rrdstore,
> +                    unit: 'bytes',
>                  },
>              ],
>              listeners: {


looks good to me, consider this:

Tested-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel