From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager v2 1/2] ui: set proxmoxRRDChart's unit at storage summary
Date: Mon, 01 Sep 2025 15:24:22 +0200 [thread overview]
Message-ID: <DCHHWBVXG7LH.27WCCTK2Y56Z6@proxmox.com> (raw)
In-Reply-To: <20250829094401.223667-1-m.sandoval@proxmox.com>
On Fri Aug 29, 2025 at 11:43 AM CEST, Maximiliano Sandoval wrote:
> This change ensures that the storage unites are displayed consistently
> between the graph and the usage label right above.
>
> When setting the unit to `bytes` the graph will now, for example, show
> "130 GB" instead of "130 G", which matches the usage displayed above and
> removes any ambiguity about whether "G" refers to GiB or GB.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>
> Differences from v1:
>
> - Use lowercase in commit name
> - Add a second commit changing the renderer of the bytes_used
>
>
> www/manager6/storage/Summary.js | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/www/manager6/storage/Summary.js b/www/manager6/storage/Summary.js
> index 8809603b..b263cb87 100644
> --- a/www/manager6/storage/Summary.js
> +++ b/www/manager6/storage/Summary.js
> @@ -52,6 +52,7 @@ Ext.define('PVE.storage.Summary', {
> fields: ['total', 'used'],
> fieldTitles: ['Total Size', 'Used Size'],
> store: rrdstore,
> + unit: 'bytes',
> },
> ],
> listeners: {
looks good to me, consider this:
Tested-by: Shannon Sterz <s.sterz@proxmox.com>
Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-09-01 13:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-29 9:43 Maximiliano Sandoval
2025-08-29 9:44 ` [pve-devel] [PATCH manager v2 2/2] api: ceph: set bytes_used's renderer to bytes Maximiliano Sandoval
2025-09-01 13:24 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCHHWBVXG7LH.27WCCTK2Y56Z6@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox