Re: [pve-devel] [PATCH manager 0/9] remove all blurry icons

["Shannon Sterz" <s.sterz@proxmox.com>]

On Thu Aug 28, 2025 at 11:45 PM CEST, Thomas Lamprecht wrote:
> On Tue, 26 Aug 2025 16:58:27 +0200, Shannon Sterz wrote:
>> this series aims to remove and replace all blurry icons. all png-based
>> icons have either been:
>>
>> a) removed because they were not used throught the code-base in the
>>    first place
>> b) adapted into svg-based versions, which replace the png versions or
>> c) removed and the code was adapted to use the already existing
>>    font-awesome icons
>>
>> [...]
>
> Applied, thanks!
>
> btw. nice solution for the spinner! Can't we override the CSS classes
> that have a `background-image:url(images/loadmask/loading.gif);` rule in
> side our CSS file from proxmox-widget-toolkit?

good point, haven't tried that yet, but will give it a go.

> FWIW, I saw other loading.gif's too, e.g. images/tree/loading.gif), that
> could be checked.

yep was also gonna check pmg and pbs for icons that are still blurry.
but pve was the biggest fish there i think.

but yeah, it seems that extjs is happy to include basically the same
spinner gif three times (images/tree/loading.gif;
images/grid/loading.gif; images/loadmask/loading.gif).

btw. seems that something has gone wrong applying patches for the ceph
and virt viewer icon. talked to christoph a bit and our best guess is
the 998 character limit according to rfc 2822 for lines in emails. both
of the svgs there have one really long path tag that seems to overrun
that limit. interestingly, every part of the toolchain (format-patch,
send-email, the mailing list and lore) dealt with that just fine, though.

i'll send a patch that reformats them and adds them back.

ps: christoph pointed me at the `--validate` option of `git send-email` that
should check just that, so i guess i'll add that to my gitconfig

> [1/9] fix #6599: ui: use font-awesome hdd icon instead of png
>       commit: 470dd9057ffbcde6e09fb9d00d13a882ffa915c1
> [2/9] ui: remove all occurences of icon-display.png
>       commit: a11f7c02e554f74488d2d0d6ceaea177e48dc552
> [3/9] ui: replace the gif spinner from extjs with an svg
>       commit: 61814591bc59f83562e977483629d334c67e38e0
> [4/9] ui: use svg version of the noVnc icon
>       commit: af50fa5836b67c1173cd3f3c55ecc8077c567802
> [5/9] ui: use svg version of the virt viewer icon
>       commit: 53cf0269a2b908f79ee48d66bfca71afb8e38e34
> [6/9] ui: use svg version of xterm.js logo instead of a png
>       commit: 1b69822949e956e66e9f1824387da6e834cc1bd5
> [7/9] ui: use the svg version for the cd icon in a storage's treelist
>       commit: fd40039e7bd6da90560736098597912a158d24d1
> [8/9] ui: replace the ceph logo png with an svg version
>       commit: 2348790ba969992dfd8235ad291e10c2823a9ebc
> [9/9] ui: remove unused png icons and their asset files
>       commit: 1b061a5d3268bc5904796527cec6e3c47413602c



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel