From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] fix #6599: ui: use font-awesome instead of png icons
Date: Tue, 26 Aug 2025 17:00:31 +0200 [thread overview]
Message-ID: <DCCG6OGBVC8Y.TXR0AS87T07L@proxmox.com> (raw)
In-Reply-To: <20250804105024.117020-1-s.sterz@proxmox.com>
superseded-by: https://lore.proxmox.com/all/20250826145836.302748-1-s.sterz@proxmox.com/T/#t
On Mon Aug 4, 2025 at 12:50 PM CEST, Shannon Sterz wrote:
> previously we used custom png rendered icons for guests and storages
> in the add menu of a pool, as well as for mountpoints for containers.
> these appeared blurry on high resolution displays and since they were
> just the same as the font-awesome icons anyway, use those directly.
> the ui already loads font-awesome regardless, so there are no
> down-sides here.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> www/manager6/grid/PoolMembers.js | 4 ++--
> www/manager6/lxc/Resources.js | 2 +-
> 2 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/www/manager6/grid/PoolMembers.js b/www/manager6/grid/PoolMembers.js
> index f025a1380..83046ee0e 100644
> --- a/www/manager6/grid/PoolMembers.js
> +++ b/www/manager6/grid/PoolMembers.js
> @@ -243,7 +243,7 @@ Ext.define('PVE.grid.PoolMembers', {
> items: [
> {
> text: gettext('Virtual Machine'),
> - iconCls: 'pve-itype-icon-qemu',
> + iconCls: 'fa fa-desktop',
> handler: function () {
> var win = Ext.create('PVE.pool.AddVM', { pool: me.pool });
> win.on('destroy', reload);
> @@ -252,7 +252,7 @@ Ext.define('PVE.grid.PoolMembers', {
> },
> {
> text: gettext('Storage'),
> - iconCls: 'pve-itype-icon-storage',
> + iconCls: 'fa fa-hdd-o',
> handler: function () {
> var win = Ext.create('PVE.pool.AddStorage', { pool: me.pool });
> win.on('destroy', reload);
> diff --git a/www/manager6/lxc/Resources.js b/www/manager6/lxc/Resources.js
> index 9f6df3a58..3defb8003 100644
> --- a/www/manager6/lxc/Resources.js
> +++ b/www/manager6/lxc/Resources.js
> @@ -128,7 +128,7 @@ Ext.define('PVE.lxc.RessourceView', {
> rows[confid] = {
> group: group,
> order: i,
> - tdCls: 'pve-itype-icon-storage',
> + iconCls: 'hdd-o',
> editor: mpeditor,
> header: header,
> renderer: Ext.htmlEncode,
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-26 15:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-04 10:50 Shannon Sterz
2025-08-04 11:20 ` Lukas Wagner
2025-08-04 11:48 ` Fiona Ebner
2025-08-04 12:10 ` Shannon Sterz
2025-08-04 12:28 ` Fiona Ebner
2025-08-26 15:00 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DCCG6OGBVC8Y.TXR0AS87T07L@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox