public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Lukas Wagner" <l.wagner@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Lukas Wagner" <l.wagner@proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] api: use 'number' instead of 'amount' for countable nouns
Date: Wed, 20 Aug 2025 15:16:58 +0200	[thread overview]
Message-ID: <DC7A84DNA9S6.1DY4YXR6KWAZM@proxmox.com> (raw)
In-Reply-To: <20250702114916.138761-1-l.wagner@proxmox.com>

On Wed Jul 2, 2025 at 1:49 PM CEST, Lukas Wagner wrote:
> Signed-off-by: Lukas Wagner <l.wagner@proxmox.com>
> ---
>  PVE/API2/Cluster.pm | 4 ++--
>  PVE/API2/Tasks.pm   | 4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/PVE/API2/Cluster.pm b/PVE/API2/Cluster.pm
> index a025d264..cda34bb3 100644
> --- a/PVE/API2/Cluster.pm
> +++ b/PVE/API2/Cluster.pm
> @@ -364,7 +364,7 @@ __PACKAGE__->register_method({
>                  },
>                  diskread => {
>                      description =>
> -                        "The amount of bytes the guest read from its block devices since"
> +                        "The number of bytes the guest read from its block devices since"
>                          . " the guest was started. This info is not available for all storage types."
>                          . " (for types 'qemu' and 'lxc')",
>                      type => 'integer',
> @@ -373,7 +373,7 @@ __PACKAGE__->register_method({
>                  },
>                  diskwrite => {
>                      description =>
> -                        "The amount of bytes the guest wrote to its block devices since"
> +                        "The number of bytes the guest wrote to its block devices since"
>                          . " the guest was started. This info is not available for all storage types."
>                          . " (for types 'qemu' and 'lxc')",
>                      type => 'integer',
> diff --git a/PVE/API2/Tasks.pm b/PVE/API2/Tasks.pm
> index 9da5b6bd..d65663f6 100644
> --- a/PVE/API2/Tasks.pm
> +++ b/PVE/API2/Tasks.pm
> @@ -63,7 +63,7 @@ __PACKAGE__->register_method({
>                  minimum => 0,
>                  default => 50,
>                  optional => 1,
> -                description => "Only list this amount of tasks.",
> +                description => "Only list this number of tasks.",
>              },
>              userfilter => {
>                  type => 'string',
> @@ -358,7 +358,7 @@ __PACKAGE__->register_method({
>                  minimum => 0,
>                  default => 50,
>                  optional => 1,
> -                description => "The amount of lines to read from the tasklog.",
> +                description => "The number of lines to read from the tasklog.",
>              },
>              download => {
>                  type => 'boolean',

bump


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  reply	other threads:[~2025-08-20 13:15 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-02 11:49 Lukas Wagner
2025-08-20 13:16 ` Lukas Wagner [this message]
2025-09-02 12:32 ` [pve-devel] applied: " Fabian Grünbichler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DC7A84DNA9S6.1DY4YXR6KWAZM@proxmox.com \
    --to=l.wagner@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal