From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>,
"Dominik Csapak" <d.csapak@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v4] ui: enable noVNC console on iOS
Date: Mon, 18 Aug 2025 12:04:18 +0200 [thread overview]
Message-ID: <DC5GVIMWTL8T.1JZ4UTTXZHAQE@noor> (raw)
In-Reply-To: <DC25E228VOUN.2MOC407ED4BLO@noor>
Superseded by v5: https://lore.proxmox.com/pve-devel/20250818100134.30550-1-s.shaji@proxmox.com/T/#t
On Thu Aug 14, 2025 at 2:26 PM CEST, Shan Shaji wrote:
> > hi,
> >
> > thanks for sending the patch again without dart format changes (mostly,
> > see my comment on the last hunk)
> >
> > while the changes themselves look ok to me, i would have liked it more
> > for the different changes to be different patches
> >
> > e.g. adding the appbar is ok, but does not have anything to do with
> > adding ios support (that change is only a single line FWICT)
> >
> > also refactoring is also always good, but having those commits
> > separate makes it much more easy to see what is actually changed.
> >
> > aside from that, there are a few comments inline
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-08-18 10:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-14 9:32 Shan Shaji
2025-08-14 11:39 ` Dominik Csapak
2025-08-14 12:26 ` Shan Shaji
2025-08-18 10:04 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DC5GVIMWTL8T.1JZ4UTTXZHAQE@noor \
--to=s.shaji@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox