From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH manager] pve8to9: don't report already migrated files as needing to be migrated
Date: Fri, 01 Aug 2025 11:29:14 +0200 [thread overview]
Message-ID: <DBQZHESCR1RZ.Q10S7M8ZWUD6@proxmox.com> (raw)
In-Reply-To: <20250801091336.68133-1-s.sterz@proxmox.com>
On Fri Aug 1, 2025 at 11:13 AM CEST, Shannon Sterz wrote:
> the find command previously also found the already migrated rrd files
> under `pve-{vm,node,storage}-9.0` and reported them as needing to
> migrate them. the provided command to would of course not migrate them
> so the warning persisted even after the command was run.
>
> limit the find command to the old `pve2-` prefixed folders to prevent
> that.
>
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> PVE/CLI/pve8to9.pm | 12 +++++++++++-
> 1 file changed, 11 insertions(+), 1 deletion(-)
>
> diff --git a/PVE/CLI/pve8to9.pm b/PVE/CLI/pve8to9.pm
> index 4d61cd831..834432b95 100644
> --- a/PVE/CLI/pve8to9.pm
> +++ b/PVE/CLI/pve8to9.pm
> @@ -1880,7 +1880,17 @@ sub check_rrd_migration {
> };
> eval {
> run_command(
> - ['find', '/var/lib/rrdcached/db', '-type', 'f', '!', '-name', '*.old'],
> + [
> + 'find',
> + '/var/lib/rrdcached/db',
> + '-path',
> + '*pve2-*',
> + '-type',
> + 'f',
> + '!',
> + '-name',
> + '*.old',
> + ],
> outfunc => $count_occurences,
> noerr => 1,
> );
I guess this should have had the following added:
Reported-by: Friedrich Weber <f.weber@proxmoc.com>
Reported-by: Daniel Herzig <d.herzig@proxmox.com>
as both have reported this issue independently from me
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-08-01 9:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-01 9:13 Shannon Sterz
2025-08-01 9:29 ` Michael Köppl
2025-08-01 9:29 ` Shannon Sterz [this message]
2025-08-01 9:32 ` Daniel Herzig
2025-08-01 11:21 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBQZHESCR1RZ.Q10S7M8ZWUD6@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox