[pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

[pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

[Shannon Sterz]

newer isos ship with new deb822 style repository configurations in
`/etc/apt/sources.list.d/debian.sources`. make the installer set the
mirror in the correct file again.

Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
---
only did some rudimentary testing here, but fixing this up might be nice
in the long run.

 Proxmox/Install.pm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/Proxmox/Install.pm b/Proxmox/Install.pm
index 3159dcc..9d8bfa8 100644
--- a/Proxmox/Install.pm
+++ b/Proxmox/Install.pm
@@ -1318,8 +1318,8 @@ _EOD

         # set apt mirror
         if (my $mirror = $iso_env->{locales}->{country}->{$country}->{mirror}) {
-            my $fn = "$targetdir/etc/apt/sources.list";
-            syscmd("sed -i 's/ftp\\.debian\\.org/$mirror/' '$fn'");
+            my $fn = "$targetdir/etc/apt/sources.list.d/debian.sources";
+            syscmd("sed -i 's/deb\\.debian\\.org/$mirror/' '$fn'");
         }

         # create extended_states for apt (avoid cron job warning if that
--
2.47.2



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

[Thomas Lamprecht]

Am 24.07.25 um 12:11 schrieb Shannon Sterz:
> newer isos ship with new deb822 style repository configurations in
> `/etc/apt/sources.list.d/debian.sources`. make the installer set the
> mirror in the correct file again.
> 
> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
> ---
> only did some rudimentary testing here, but fixing this up might be nice
> in the long run.

Thanks & good catch!

Something that I wondered for a while is if it's still useful to point
to the per-country mirror hostnames, or if the fastly provided CDN is the
better option though. Probably depends a bit on the quality of the
respective per-country mirrors.

@Fabian, do you maybe have any better info here?


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

[Fabian Grünbichler]

On July 24, 2025 4:35 pm, Thomas Lamprecht wrote:
> Am 24.07.25 um 12:11 schrieb Shannon Sterz:
>> newer isos ship with new deb822 style repository configurations in
>> `/etc/apt/sources.list.d/debian.sources`. make the installer set the
>> mirror in the correct file again.
>> 
>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>> ---
>> only did some rudimentary testing here, but fixing this up might be nice
>> in the long run.
> 
> Thanks & good catch!
> 
> Something that I wondered for a while is if it's still useful to point
> to the per-country mirror hostnames, or if the fastly provided CDN is the
> better option though. Probably depends a bit on the quality of the
> respective per-country mirrors.
> 
> @Fabian, do you maybe have any better info here?

fastly/deb.debian.org is the suggested mirror upstream as well nowadays:

https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH installer] install: adapt to changes in repository config when setting mirror

[Shannon Sterz]

On Thu Jul 31, 2025 at 11:00 AM CEST, Fabian Grünbichler wrote:
> On July 24, 2025 4:35 pm, Thomas Lamprecht wrote:
>> Am 24.07.25 um 12:11 schrieb Shannon Sterz:
>>> newer isos ship with new deb822 style repository configurations in
>>> `/etc/apt/sources.list.d/debian.sources`. make the installer set the
>>> mirror in the correct file again.
>>>
>>> Signed-off-by: Shannon Sterz <s.sterz@proxmox.com>
>>> ---
>>> only did some rudimentary testing here, but fixing this up might be nice
>>> in the long run.
>>
>> Thanks & good catch!
>>
>> Something that I wondered for a while is if it's still useful to point
>> to the per-country mirror hostnames, or if the fastly provided CDN is the
>> better option though. Probably depends a bit on the quality of the
>> respective per-country mirrors.
>>
>> @Fabian, do you maybe have any better info here?
>
> fastly/deb.debian.org is the suggested mirror upstream as well nowadays:
>
> https://www.debian.org/releases/trixie/release-notes/upgrading.en.html#adding-apt-internet-sources

i'd send patch that removes the if-statement in question here then. we
might want to remove the `debmirrors` function from `Tools.pm` in
`pve-common` too.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel