Re: [pve-devel] [PATCH proxmox-datacenter-manager v2 1/2] add context to translatable strings

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  ui/src/dashboard/top_entities.rs | 1 +
>  ui/src/pve/qemu.rs               | 2 ++
>  ui/src/remotes/add_wizard.rs     | 1 +
>  3 files changed, 4 insertions(+)
>
> diff --git a/ui/src/dashboard/top_entities.rs b/ui/src/dashboard/top_entities.rs
> index af3f853..4859e64 100644
> --- a/ui/src/dashboard/top_entities.rs
> +++ b/ui/src/dashboard/top_entities.rs
> @@ -238,6 +238,7 @@ fn create_tooltip(
>      Column::new()
>          .min_width(200)
>          .gap(2)
> +        // TRANSLATORS: For example "resource on Remote 'HAL 9000'"
>          .with_child(Container::from_tag("h6").with_child(tr! {
>              "{0} on Remote '{1}'",
>              render_resource_name(resource, false),
> diff --git a/ui/src/pve/qemu.rs b/ui/src/pve/qemu.rs
> index 57e5e74..fbf42e5 100644
> --- a/ui/src/pve/qemu.rs
> +++ b/ui/src/pve/qemu.rs
> @@ -201,7 +201,9 @@ impl yew::Component for QemuPanelComp {
>                          self.cpu = Rc::new(Series::new(tr!("CPU usage"), cpu));
>                          self.memory = Rc::new(Series::new(tr!("RAM usage"), memory));
>                          self.memory_max = Rc::new(Series::new(tr!("Total"), memory_max));
> +                        // TRANSLATORS: As in ammount of incoming network traffic

nit: typo, amount not ammount

>                          self.netin = Rc::new(Series::new(tr!("Net In"), netin));
> +                        // TRANSLATORS: As in ammount of outgoin network traffic

nit: typo, amount and should be "outgoing"

>                          self.netout = Rc::new(Series::new(tr!("Net Out"), netout));
>                          self.diskread = Rc::new(Series::new(tr!("Disk Read"), diskread));
>                          self.diskwrite = Rc::new(Series::new(tr!("Disk Write"), diskwrite));
> diff --git a/ui/src/remotes/add_wizard.rs b/ui/src/remotes/add_wizard.rs
> index f4bf9a3..12d64f3 100644
> --- a/ui/src/remotes/add_wizard.rs
> +++ b/ui/src/remotes/add_wizard.rs
> @@ -96,6 +96,7 @@ impl Component for AddWizardState {
>                  TabBarItem::new()
>                      .key("connection")
>                      .label(if remote_type == RemoteType::Pve {
> +                        // TRANSLATORS: Probe is a verb here
>                          tr!("Probe Remote")
>                      } else {
>                          tr!("Connection")



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel