Re: [pve-devel] [PATCH yew-widget-toolkit v2 1/1] improve translatable strings

["Shannon Sterz" <s.sterz@proxmox.com>]

On Wed Jul 30, 2025 at 12:38 PM CEST, Maximiliano Sandoval wrote:
> We error when the fields are empty, hence must is more appropiate.
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
>  src/widget/form/field.rs    | 2 +-
>  src/widget/form/number.rs   | 4 ++--
>  src/widget/form/selector.rs | 2 +-
>  src/widget/form/textarea.rs | 2 +-
>  4 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/widget/form/field.rs b/src/widget/form/field.rs
> index 314b5e16..da3b9777 100644
> --- a/src/widget/form/field.rs
> +++ b/src/widget/form/field.rs
> @@ -329,7 +329,7 @@ impl ManagedField for StandardField {
>
>          if value.is_empty() {
>              if props.required {
> -                return Err(Error::msg(tr!("Field may not be empty.")));
> +                return Err(Error::msg(tr!("Field must not be empty.")));
>              } else {
>                  return Ok(Value::String(String::new()));
>              }
> diff --git a/src/widget/form/number.rs b/src/widget/form/number.rs
> index 78d44a39..298b4c8b 100644
> --- a/src/widget/form/number.rs
> +++ b/src/widget/form/number.rs
> @@ -433,7 +433,7 @@ impl<T: NumberTypeInfo> ManagedField for NumberField<T> {
>
>          if is_empty {
>              if props.required {
> -                return Err(Error::msg(tr!("Field may not be empty.")));
> +                return Err(Error::msg(tr!("Field must not be empty.")));
>              } else {
>                  return Ok(Value::Null);
>              }
> @@ -441,7 +441,7 @@ impl<T: NumberTypeInfo> ManagedField for NumberField<T> {
>
>          let number = match T::value_to_number(value) {
>              Ok(number) => number,
> -            Err(err) => return Err(Error::msg(tr!("Input invalid: {}", err.to_string()))),
> +            Err(err) => return Err(Error::msg(tr!("Invalid input: {}", err.to_string()))),

nit: this change seems unrelated to the reasoning above, might be nice
to get that added to the commit message or split it out.

-->8 snip 8<--


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel