Re: [pve-devel] [PATCH manager v4 14/15] d/postinst: run promox-rrd-migration-tool

["Lukas Wagner" <l.wagner@proxmox.com>]

On Sat Jul 26, 2025 at 3:06 AM CEST, Aaron Lauterer wrote:
> Signed-off-by: Aaron Lauterer <a.lauterer@proxmox.com>
> ---
>
> Notes:
>     currently it checks for lt 9.0.0~12. should it only be applied to a
>     later version, don't forget to adapt the version check!
>     
>     I tested it by bumping the version to 9.0.0~12
>     upgraded to it -> migration ran
>     reinstalled -> no migration happening
>     
>     when installing the bumped pve-manager package and the
>     proxmox-rrd-migration-tool package at the same time, dependencies are
>     resolved and the postinst script works.
>     
>     There is still one bug though that happens on my live system: While the
>     migration tool moves the processed files to FILE.old, new ones without
>     the .old are still present.
>     I did a quick try, disabling rrdached before we call the migration tool.
>     But that didn't help. Could be that pmxcfs is receiving new data and is
>     recreating them. Or maybe something else.
>     That would need to be debugged to figure out as apparently I did miss
>     something here regarding the behavior.
>
>  debian/postinst | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/debian/postinst b/debian/postinst
> index a0480b24..b15603ac 100755
> --- a/debian/postinst
> +++ b/debian/postinst
> @@ -227,6 +227,11 @@ case "$1" in
>              migrate_apt_auth_conf
>          fi
>      fi
> +
> +    if test -n "$2" && dpkg --compare-versions "$2" 'lt' '9.0.0~12'; then
> +        echo "migradting RRD to new PVE format version - this can take some time!"

small typo in 'migrating'

> +        proxmox-rrd-migration-tool --migrate || echo "migration failed, see output above for errors and try to migrate existing data manually by running 'proxmox-rrd-migration-tool --migrate'"
> +    fi
>      ;;
>  
>    abort-upgrade|abort-remove|abort-deconfigure)



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel