Re: [pve-devel] [PATCH proxmox-rrd-migration-tool v4 3/3] add debian packaging

["Lukas Wagner" <l.wagner@proxmox.com>]

On Tue Jul 29, 2025 at 11:29 AM CEST, Thomas Lamprecht wrote:
> Am 28.07.25 um 16:36 schrieb Lukas Wagner:
>>> diff --git a/debian/links b/debian/links
>>> new file mode 100644
>>> index 0000000..9e59b57
>>> --- /dev/null
>>> +++ b/debian/links
>>> @@ -0,0 +1 @@
>>> +usr/libexec/proxmox/proxmox-rrd-migration-tool usr/bin/proxmox-rrd-migration-tool
>> As far as I understand this is a tool that should be called directly by
>> a user, right? In that case I'd not add the symlink but alter the
>> Makefile so that it installs it to /usr/bin/ right away.
>
> It actually shouldn't, the migration should be handled automatically and
> the tool only called manually in the edge case, in which providing the full
> path (e.g., in the respective 8to9 check output) is enough.

Ah yeah, wrote this comment before actually looking into the pve-manager
patches, missed that it is supposed to be called by d/postinst.

>
> So while you're definitively right in that this way is not gaining us
> anything (good catch!), I'd rather just drop the symnlink in /usr/bin and
> keep it only in libexec.

Agreed, in this case I'd also just drop the symlink.

Thanks for the clarification!



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel