public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by
Date: Wed, 23 Jul 2025 11:53:32 +0200	[thread overview]
Message-ID: <DBJCD3XVJWRG.1VJDYSVH2G1TK@proxmox.com> (raw)
In-Reply-To: <20250721113540.151366-1-m.sandoval@proxmox.com>

On Mon Jul 21, 2025 at 1:35 PM CEST, Maximiliano Sandoval wrote:
> translator editors and will appear in po files as
>
> ```
> #. TRANSLATORS: Stands for Complete Sequence Number Packet, see
> #. https://datatracker.ietf.org/doc/html/draft-ietf-lsr-distoptflood#name-flooding-failures
> #: pve-manager/www/manager6/sdn/fabrics/openfabric/FabricEdit.js:61
> msgid "CSNP Interval"
> msgstr "Intervalo de CSNP"
> ```
>
> pve-manager:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  www/manager6/grid/BackupView.js                   | 1 +
>  www/manager6/sdn/fabrics/openfabric/FabricEdit.js | 3 +++
>  www/manager6/sdn/zones/VxlanEdit.js               | 1 +
>  www/manager6/storage/BackupView.js                | 1 +
>  www/manager6/storage/Base.js                      | 1 +
>  www/manager6/window/Backup.js                     | 1 +
>  6 files changed, 8 insertions(+)
>
>
> proxmox-widget-toolkit:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  src/form/MultiDiskSelector.js | 1 +
>  1 file changed, 1 insertion(+)
>
>
> pmg-gui:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  js/MailProxyDKIMPanel.js | 2 ++
>  js/Utils.js              | 2 ++
>  2 files changed, 4 insertions(+)
>
>
> proxmox-backup:
>
> Maximiliano Sandoval (1):
>   add context to some translations
>
>  www/tape/DriveStatus.js     | 1 +
>  www/window/DataStoreEdit.js | 1 +
>  2 files changed, 2 insertions(+)
>
>
> Summary over all repositories:
>   11 files changed, 15 insertions(+), 0 deletions(-)


This series looks good to me, i applied the patches and the strings show
up in the *.po files and, thus, poedit, after running make do_update (to
avoid possibly resetting the submodules again). So consider all four
patches:

Reviewed-by: Shannon Sterz <s.sterz@proxmox.com>
Tested-by: Shannon Sterz <s.sterz@proxmox.com>


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


  parent reply	other threads:[~2025-07-23  9:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-21 11:35 Maximiliano Sandoval
2025-07-21 11:35 ` [pve-devel] [PATCH manager 1/1] add context to some translations Maximiliano Sandoval
2025-07-21 11:35 ` [pve-devel] [PATCH widget-toolkit " Maximiliano Sandoval
2025-07-21 11:35 ` [pve-devel] [PATCH pmg-gui " Maximiliano Sandoval
2025-07-21 11:35 ` [pve-devel] [PATCH backup " Maximiliano Sandoval
2025-07-23  9:53 ` Shannon Sterz [this message]
2025-07-30 10:58   ` [pve-devel] superseded: [PATCH backup/manager/pmg-gui/widget-toolkit 0/4] Add context to multiple translatable strings. These will be displayed by Maximiliano Sandoval

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DBJCD3XVJWRG.1VJDYSVH2G1TK@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel-bounces@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal