From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Dominik Csapak" <d.csapak@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] chore: ios: update bundle identifier and display name
Date: Wed, 16 Jul 2025 09:35:46 +0200 [thread overview]
Message-ID: <DBDB1T4ZM1SL.2D4P5S0DLSG48@noor> (raw)
In-Reply-To: <c5950500-9dd0-4a55-8a12-96f08cd89fd2@proxmox.com>
Hey, I changed the bundle identifier to match with the bundle
identifier that thomas created in the apple developer console. Also the same
identifier is used inside the app store connect to create the app
record.
On Tue Jul 15, 2025 at 1:28 PM CEST, Dominik Csapak wrote:
> On 7/10/25 10:44, Shan Shaji wrote:
> > For iOS, the bundle identifier and display name were incorrect. The
> > issue was fixed by updating the bundle identifier to
> > `com.proxmox.proxmox-ve-companion` and the display name to "Proxmox VE".
>
> ok i understand the name change, but what exactly was wrong with
>
> 'com.proxmox.pveFlutterFrontend' ?
>
> are there any guidelines or rules in the app store that would prevent us from using that?
>
> I'm not saying we can't change this, but it would be good to record the reason at least...
I will create a new patch with the reason of why it was changed.
> Aside from that the patch looks good to me:
>
> Reviewed-by: Dominik Csapak <d.csapak@proxmox.com>
>
> side note: I'd like to have a testbed where i could test ios changes before i start applying
> things...
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-16 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-10 8:44 Shan Shaji
2025-07-15 11:28 ` Dominik Csapak
2025-07-16 7:35 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DBDB1T4ZM1SL.2D4P5S0DLSG48@noor \
--to=s.shaji@proxmox.com \
--cc=d.csapak@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox