From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
<pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend v2] chore: assets: update flutter app icons in iOS with proxmox icons
Date: Thu, 10 Jul 2025 11:50:43 +0200 [thread overview]
Message-ID: <DB8A5VDRG8QP.1KRRSUO1KBYC5@noor> (raw)
In-Reply-To: <175197026204.3270283.6151201494562293294.b4-ty@proxmox.com>
Hi Thomas,
Thanks for catching that. I have created another patch [0] after updating
the icon.
- [0] https://lore.proxmox.com/pve-devel/20250710094652.16608-1-s.shaji@proxmox.com/T/#u
Thanks!
On Tue Jul 8, 2025 at 12:26 PM CEST, Thomas Lamprecht wrote:
> On Thu, 22 May 2025 11:50:00 +0200, Shan Shaji wrote:
> > When running the app in iOS the app icon was the default flutter
> > icon and this commit fixes it by replacing all
> > flutter icons with the proxmox app icon.
> >
>
> Applied, thanks!
>
> FWIW, there is still one default icon left:
> ios/Runner/Assets.xcassets/AppIcon.appiconset/Icon-App-83.5x83.5@2x.png
>
>
> [1/1] chore: assets: update flutter app icons in iOS with proxmox icons
> commit: 0749713b016909daca4c87282ce925aafca049a2
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-07-10 9:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-22 9:50 Shan Shaji
2025-07-07 11:51 ` Shan Shaji
2025-07-08 10:26 ` Thomas Lamprecht
2025-07-10 9:50 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DB8A5VDRG8QP.1KRRSUO1KBYC5@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox