Re: [pve-devel] [PATCH proxmox_login_manager] ui: settings: add privacy policy url link in settings screen

["Shan Shaji" <s.shaji@proxmox.com>]

Thank you Dominik, Will keep that in mind. I have created a new patch 
by including the changes that you mentioned. 

superseeded by v2: https://lore.proxmox.com/pve-devel/20250704152654.21221-1-s.shaji@proxmox.com/T/#t

On Mon Jul 7, 2025 at 8:28 AM CEST, Dominik Csapak wrote:
> On 7/4/25 16:40, Shan Shaji wrote:
> > On Thu Jul 3, 2025 at 4:00 PM CEST, Dominik Csapak wrote:
> >>> +      backgroundColor: Theme.of(context).colorScheme.surfaceContainer,
> >>
> >> this change seems to be unrelated?
> > This was intended. The change was made to match the backgroundColor of
> > `ProxmoxLoginSelector`. Previously it was using the default scaffold
> > backgroundColor.
>
> ok. In this case it was not really clear why it was done in this patch, so a short
> sentence that this is changed too wouldn't hurt IMHO.

Also this change is not included in the new patch. I have removed it. 
> >>
> >>>          appBar: AppBar(
> >>>            title: const Text('Settings'),
> >>>          ),
> >>> @@ -45,6 +51,32 @@ class _ProxmoxGeneralSettingsFormState
> >>>                                  ProxmoxGeneralSettingsModel.fromLocalStorage();
> >>>                            });
> >>>                          },
> >>> +                    ),
> >>> +                    PveSettingsSection(
> >>> +                      title: 'LEGAL',
> >>> +                      children: [
> >>> +                        PveSettingsItem(
> >>> +                          titleString: 'Privacy Policy',
> >>> +                          leadingIcon: Icons.privacy_tip_outlined,



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel