From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Michael Köppl" <m.koeppl@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm
Date: Tue, 17 Jun 2025 14:32:01 +0200 [thread overview]
Message-ID: <DAOT6U848B4A.90XM5SLF379B@noor> (raw)
In-Reply-To: <df3f8789-7625-4578-adb8-2108a60cbbd6@proxmox.com>
Ping
On Fri Jun 6, 2025 at 10:18 AM CEST, Michael Köppl wrote:
> Gave this another spin in my Android emulator. User's realm selection is
> now respected if there is one, otherwise the site's selected default is
> used. Did not notice anything off. With my comments from v2 addressed
> and everything working as expected, consider this:
>
> Reviewed-by: Michael Köppl <m.koeppl@proxmox.com>
> Tested-by: Michael Köppl <m.koeppl@proxmox.com>
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-06-17 12:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-03 12:20 Shan Shaji
2025-06-03 12:20 ` [pve-devel] [PATCH proxmox_login_manager v3 1/1] fix #6409: add `isDefaultRealm` check to pre-select realm in login form Shan Shaji
2025-06-03 12:20 ` [pve-devel] [PATCH proxmox_dart_api_client v3 1/1] fix #6409: add `default` property to `PveAccessDomainModel` Shan Shaji
2025-06-06 8:18 ` [pve-devel] [PATCH proxmox{_login_manager, _dart_api_client} v3 0/2] fix #6409: login manager doesn't pre-selects default authentication realm Michael Köppl
2025-06-17 12:32 ` Shan Shaji [this message]
2025-07-01 11:55 ` [pve-devel] applied: " Dominik Csapak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DAOT6U848B4A.90XM5SLF379B@noor \
--to=s.shaji@proxmox.com \
--cc=m.koeppl@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox