public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
	"Michael Köppl" <m.koeppl@proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] fix: ui: overflow error when `pending` chip comes to view
Date: Mon, 16 Jun 2025 16:12:22 +0200	[thread overview]
Message-ID: <DAO0P4NG41I4.1G0LNB7KJA45P@noor> (raw)
In-Reply-To: <DANXZEI3KAF9.27IKHUQM3HJ3Y@noor>

Superseeded By v2: https://lore.proxmox.com/pve-devel/20250616125844.52117-1-s.shaji@proxmox.com/T/#u

On Mon Jun 16, 2025 at 2:04 PM CEST, Shan Shaji wrote:
>
> Thanks for the review. Will send another updated patch. 
>
> On Fri Jun 13, 2025 at 1:19 PM CEST, Michael Köppl wrote:
> > Quickly tested this in my Android emulator by following the steps
> > described in the commit message (comment on that below). Was able to
> > reproduce the issue before the patch. Good that you found this. With the
> > patch applied, the render flex error does not appear anymore. Tested
> > that it works with portrait and landscape. Did not notice anything off
> > in the UI and I think it's a good solution to still make the pending
> > chip fit somewhere.
> >
> > Consider this:
> > Tested-by: Michael Köppl <m.koeppl@proxmox.com>
> >
> > On 6/12/25 11:53, Shan Shaji wrote:
> > > When the pending chip appears after enabling an option from the options
> > > page, Flutter throws an overflow error, causing the chip to render
> > > on top of the Switch widget due to insufficient space between
> > > the title and the switch toggle.
> > > 
> > > To resolve this, modify the layout so that the pending chip widget
> > > is rendered in a column instead of a row.
> > > 
> >
> > I think the commit message would benefit from being rephrased to
> > something like "fix: guest config: render pending chip widget in Column
> > instead of Row to avoid render flex error when using option toggles", as
> > that is the part that semantically changes and it more clearly states
> > *where* the change was made.
> >
> > > Steps to reproduce the issue:
> > >   - Navigate to the options tab of any VM.
> > >   - Enable the "KVM hardware virtualization" option.
> > >   - You will encounter a render flex error.
> >
> > This should go under the --- as otherwise it'll be included in the
> > commit message.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

      reply	other threads:[~2025-06-16 14:12 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-06-12  9:53 Shan Shaji
2025-06-13 11:19 ` Michael Köppl
2025-06-16 12:04   ` Shan Shaji
2025-06-16 14:12     ` Shan Shaji [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DAO0P4NG41I4.1G0LNB7KJA45P@noor \
    --to=s.shaji@proxmox.com \
    --cc=m.koeppl@proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal