Re: [pve-devel] [PATCH qemu-server v2 7/13] fix #5180: libexec: add QEMU dbus-vmstate daemon for migrating conntrack

From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH qemu-server v2 7/13] fix #5180: libexec: add QEMU dbus-vmstate daemon for migrating conntrack
Date: Wed, 11 Jun 2025 12:44:45 +0200	[thread overview]
Message-ID: <DAJN5FOTU2VU.1K2DHZWUA99SC@proxmox.com> (raw)
In-Reply-To: <da8f3a27-7109-4f3b-98bc-5a797cb26ac5@proxmox.com>

On Tue Jun 3, 2025 at 11:34 AM CEST, Stefan Hanreich wrote:
> On 4/24/25 13:19, Christoph Heiss wrote:
>> +sub Load {
>> +    my ($self, $bytes) = @_;
>> +
>> +    my $len = scalar(@$bytes);
>> +    return if $len <= 1; # see also the `Save` method
>> +
>> +    my $text = pack('c*', @$bytes);
>> +
>> +    eval {
>> +	PVE::Tools::run_command(
>> +	    ['conntrack', '--load-file', '-'],
>> +	    input => $text,
>> +	);
>> +    };
>> +    if (my $err = $@) {
>
> nit: could just use $@ directly here? some additional occurences below

Yeah indeed, just bit a muscle memory on my side, since it also avoids
accidentally overwriting/propagating the wrong error, in case $@ get's
set again, with $@ being quite magic.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel