From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shan Shaji" <s.shaji@proxmox.com>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] ui: replace deprecated `onBackground` property
Date: Tue, 27 May 2025 14:28:44 +0200 [thread overview]
Message-ID: <DA6XYVO2XMIN.33E2PWVL39SIL@noor> (raw)
In-Reply-To: <20250505143331.83707-1-s.shaji@proxmox.com>
Ping
On Mon May 5, 2025 at 4:33 PM CEST, Shan Shaji wrote:
> As of flutter v3.22, the `onBackground` property is deprecated. The
> material guidelines suggest using the `onSurface` property instead.
>
> https://m3.material.io/styles/color/roles#8562cf18-5cc0-44ae-b783-2e38bdb39585
>
> For dark theme, the `onSurface` color and `onBackground` color is
> different so it's not possible to directly replace the `onBackground`
> with the `onSurface` property. This patch adds a new `onSurfaceVariant`
> property to the theme and replaces all instances of `onBackground`
> with `onSurfaceVariant`.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-05-27 12:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-05 14:33 Shan Shaji
2025-05-27 12:28 ` Shan Shaji [this message]
2025-06-04 10:11 ` Dominik Csapak
2025-06-05 6:57 ` Shan Shaji
2025-06-05 8:25 ` Shan Shaji
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA6XYVO2XMIN.33E2PWVL39SIL@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal