From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox_login_manager] refactor: rename `MaterialState` to `WidgetState`
Date: Thu, 22 May 2025 09:32:06 +0200 [thread overview]
Message-ID: <DA2IJ1FOF3VT.Z85LVVKW2DDW@noor> (raw)
In-Reply-To: <d1144871-6407-4d7d-97ea-cba6b2114ae2@proxmox.com>
Thank you so much for the review. I will seperate this into multiple
patches.
On Wed May 21, 2025 at 1:12 PM CEST, Dominik Csapak wrote:
> not a super big issue, but 2 hunks seem to be unrelated to the commit message
> (see inline)
>
> it would be much nicer to have the commits clean, so I'd appreciate it when you send
> a v2 that either
> * has separate patches for the different things (i would much prefer that)
> * change the commit message to include what is fixed/improved
> _______________________________________________
> pve-devel mailing list
> pve-devel@lists.proxmox.com
> https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-05-22 7:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-13 12:46 Shan Shaji
2025-05-21 11:12 ` Dominik Csapak
2025-05-22 7:32 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DA2IJ1FOF3VT.Z85LVVKW2DDW@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox