[pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback

[pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback

[Shan Shaji]

The `onPopInvoked` callback is deprecated as of
Flutter v3.22.0-12.0.pre. This patch replaces it
with the `onPopInvokedWithResult`  callback.

Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
---
 lib/pages/main_layout_slim.dart         | 2 +-
 lib/states/pve_node_overview_state.dart | 2 --
 2 files changed, 1 insertion(+), 3 deletions(-)

diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
index 322bcac..8c4cacb 100644
--- a/lib/pages/main_layout_slim.dart
+++ b/lib/pages/main_layout_slim.dart
@@ -71,7 +71,7 @@ class _MainLayoutSlimState extends State<MainLayoutSlim> {
       ],
       child: PopScope(
         canPop: false,
-        onPopInvoked: (didPop) async {
+        onPopInvokedWithResult: (didPop, _) {
           if (didPop || pageSelector.value != 0) {
             if (pageSelector.value != 0) pageSelector.add(0);
             return;
diff --git a/lib/states/pve_node_overview_state.dart b/lib/states/pve_node_overview_state.dart
index 132764c..64353f8 100644
--- a/lib/states/pve_node_overview_state.dart
+++ b/lib/states/pve_node_overview_state.dart
@@ -1,5 +1,3 @@
-library pve_node_overview_state;
-
 import 'package:built_collection/built_collection.dart';
 import 'package:built_value/built_value.dart';
 import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';
-- 
2.39.5


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback

[Shannon Sterz]

On Mon Apr 28, 2025 at 4:03 PM CEST, Shan Shaji wrote:
> The `onPopInvoked` callback is deprecated as of
> Flutter v3.22.0-12.0.pre. This patch replaces it
> with the `onPopInvokedWithResult`  callback.
>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  lib/pages/main_layout_slim.dart         | 2 +-
>  lib/states/pve_node_overview_state.dart | 2 --
>  2 files changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/lib/pages/main_layout_slim.dart b/lib/pages/main_layout_slim.dart
> index 322bcac..8c4cacb 100644
> --- a/lib/pages/main_layout_slim.dart
> +++ b/lib/pages/main_layout_slim.dart
> @@ -71,7 +71,7 @@ class _MainLayoutSlimState extends State<MainLayoutSlim> {
>        ],
>        child: PopScope(
>          canPop: false,
> -        onPopInvoked: (didPop) async {
> +        onPopInvokedWithResult: (didPop, _) {

is eremoving the `async` keyword here intentional? if so, it might be
worth documenting why you removed it.

>            if (didPop || pageSelector.value != 0) {
>              if (pageSelector.value != 0) pageSelector.add(0);
>              return;
> diff --git a/lib/states/pve_node_overview_state.dart b/lib/states/pve_node_overview_state.dart
> index 132764c..64353f8 100644
> --- a/lib/states/pve_node_overview_state.dart
> +++ b/lib/states/pve_node_overview_state.dart
> @@ -1,5 +1,3 @@
> -library pve_node_overview_state;
> -

this seems unrelated, did you mean to remove the library declaration of
this files?

>  import 'package:built_collection/built_collection.dart';
>  import 'package:built_value/built_value.dart';
>  import 'package:proxmox_dart_api_client/proxmox_dart_api_client.dart';



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback

[Shan Shaji]

Hey, thank you for the review. Removal of the library declaration was 
intentional as it's a linting issue and not necessary anymore in 
the newer versions of flutter. Added it in the same patch as 
it was a small change. 

Removal of `async` keyword was not intentional and will revert 
the change. I will document and create another patch.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel