From: "Shan Shaji" <s.shaji@proxmox.com>
To: "Shannon Sterz" <s.sterz@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] navigation: replace deprecated `onPopInvoked` callback
Date: Tue, 29 Apr 2025 12:59:34 +0200 [thread overview]
Message-ID: <D9J2JCYUGFYD.1T5INMZ64TSZ2@noor> (raw)
In-Reply-To: <D9IZ84LXPBV9.1HWY3EOEB7F4B@proxmox.com>
Hey, thank you for the review. Removal of the library declaration was
intentional as it's a linting issue and not necessary anymore in
the newer versions of flutter. Added it in the same patch as
it was a small change.
Removal of `async` keyword was not intentional and will revert
the change. I will document and create another patch.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-29 10:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-28 14:03 Shan Shaji
2025-04-29 8:23 ` Shannon Sterz
2025-04-29 10:59 ` Shan Shaji [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D9J2JCYUGFYD.1T5INMZ64TSZ2@noor \
--to=s.shaji@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=s.sterz@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal