public inbox for pve-devel@lists.proxmox.com
 help / color / mirror / Atom feed
From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: Shan Shaji <s.shaji@proxmox.com>,
	pve-devel <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve_flutter_frontend] gitignore: add generated dart files
Date: Thu, 24 Apr 2025 14:15:58 +0200	[thread overview]
Message-ID: <D9EV14VROB66.3AVL7KTTFLIR7@proxmox.com> (raw)
In-Reply-To: <20250424105441.76823-1-s.shaji@proxmox.com>

On Thu Apr 24, 2025 at 12:54 PM CEST, Shan Shaji wrote:
> Omit `devtools_options.yaml` file and generated dart files
> from source control.
>
> `devtools_options.yaml` file is a config file for storing the
> extension enablement states of flutter dev tools. By adding `devtools_options.yaml`
> as an entry in the `.gitignore` file, the configurations will be seperate for each developer.

just a small nit, the two lines above are longer than the 72 characters
suggested by our commit message style guide [1]. please make sure that
whatever editor you use enforce the hard line wrapping here correctly :)

[1]: https://pve.proxmox.com/wiki/Developer_Documentation#Commits_and_Commit_Messages

>
> Signed-off-by: Shan Shaji <s.shaji@proxmox.com>
> ---
>  .gitignore | 3 +++
>  1 file changed, 3 insertions(+)
>
> diff --git a/.gitignore b/.gitignore
> index 3c88cc5..5e91008 100644
> --- a/.gitignore
> +++ b/.gitignore
> @@ -43,3 +43,6 @@ app.*.map.json
>  /android/app/debug
>  /android/app/profile
>  /android/app/release
> +
> +*.g.dart
> +devtools_options.yaml
> \ No newline at end of file



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel


      reply	other threads:[~2025-04-24 12:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-24 10:54 Shan Shaji
2025-04-24 12:15 ` Shannon Sterz [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=D9EV14VROB66.3AVL7KTTFLIR7@proxmox.com \
    --to=s.sterz@proxmox.com \
    --cc=pve-devel-bounces@lists.proxmox.com \
    --cc=pve-devel@lists.proxmox.com \
    --cc=s.shaji@proxmox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal