From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>
Cc: pve-devel@lists.proxmox.com
Subject: Re: [pve-devel] [PATCH manager v2 1/2] window: migrate: make all user-visible strings translatable
Date: Mon, 07 Apr 2025 12:49:03 +0200 [thread overview]
Message-ID: <D90CJBJUO0Y6.CN9YRQ0BH833@proxmox.com> (raw)
In-Reply-To: <174401995303.2626354.5380020422632639795.b4-ty@proxmox.com>
On Mon Apr 7, 2025 at 12:06 PM CEST, Thomas Lamprecht wrote:
>
> On Mon, 07 Apr 2025 11:16:27 +0200, Christoph Heiss wrote:
>> Quite a few user-visible strings in the dialog currently are not using
>> gettext(), thus not making them translatable.
>>
>> While at it, also remove some contractions from error/warning messages.
>> Not strictly necessary per our style guide, but it avoids escaping
>> single quotes and reads quite a bit nicer IMHO.
>>
>> [...]
>
> Applied, fixed the subject to start with a `ui` tag and then
> use a slightly more verbose `guest migrate window` second
> level tag, thanks!
Thanks! Not sure how I missed the `ui:` commit tag on this, will do a
double-take on this matter in the future.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2025-04-07 10:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-07 9:16 Christoph Heiss
2025-04-07 9:16 ` [pve-devel] [PATCH manager v2 2/2] window: migrate: use predefined constant for error alert title Christoph Heiss
2025-04-07 10:06 ` [pve-devel] [PATCH manager v2 1/2] window: migrate: make all user-visible strings translatable Thomas Lamprecht
2025-04-07 10:49 ` Christoph Heiss [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D90CJBJUO0Y6.CN9YRQ0BH833@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal