Re: [pve-devel] [PATCH proxmox-ve-rs v2 1/1] ve-config: move types to proxmox-network-types

From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Stefan Hanreich" <s.hanreich@proxmox.com>
Cc: Proxmox VE development discussion <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs v2 1/1] ve-config: move types to proxmox-network-types
Date: Wed, 02 Apr 2025 10:39:03 +0200	[thread overview]
Message-ID: <D8W0N2I2SFYQ.N3X4NZYBWP0J@proxmox.com> (raw)
In-Reply-To: <20250401133616.331046-3-s.hanreich@proxmox.com>

Just a quick note:

On Tue Apr 1, 2025 at 3:36 PM CEST, Stefan Hanreich wrote:
[..]
> diff --git a/proxmox-ve-config/src/firewall/types/address.rs b/proxmox-ve-config/src/firewall/types/address.rs
> index 9b73d3d..548b813 100644
> --- a/proxmox-ve-config/src/firewall/types/address.rs
> +++ b/proxmox-ve-config/src/firewall/types/address.rs
[..]
> -        assert_eq!(
> -            [Ipv6Cidr::new(
> -                [0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF, 0xFFFF],
> -                128
> -            )
> -            .unwrap(),],
> -            range.to_cidrs().as_slice()
> -        );
> -    }
>  }
> +

nit: new blank line at eof, guess just an accidental typo? :^)

Came across it while applying the patch for a quick compile-test.

  Applying: ve-config: move types to proxmox-network-types
  .git/rebase-apply/patch:1548: new blank line at EOF.
  +
  warning: 1 line adds whitespace errors.

Just wanted to mention, can easily be fixed up during applying as well.
Definitely not worth a resend in any case, IMO.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel