From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-firewall] tests: integration: silence warning about unused variable
Date: Wed, 26 Mar 2025 10:25:14 +0100 [thread overview]
Message-ID: <D8Q38M7I4N2H.1BUOMI8OBGWXW@proxmox.com> (raw)
In-Reply-To: <20250225102908.286921-1-c.heiss@proxmox.com>
Ping, still applies.
On Tue Feb 25, 2025 at 11:28 AM CET, Christoph Heiss wrote:
> It's just a stub method, so this gets never used.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-firewall/tests/integration_tests.rs | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/proxmox-firewall/tests/integration_tests.rs b/proxmox-firewall/tests/integration_tests.rs
> index 61a8062..1c014ad 100644
> --- a/proxmox-firewall/tests/integration_tests.rs
> +++ b/proxmox-firewall/tests/integration_tests.rs
> @@ -87,7 +87,7 @@ impl FirewallConfigLoader for MockFirewallConfigLoader {
>
> fn bridge_firewall_config(
> &self,
> - bridge_name: &BridgeName,
> + _bridge_name: &BridgeName,
> ) -> Result<Option<Box<dyn std::io::BufRead>>, Error> {
> Ok(None)
> }
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-03-26 9:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-25 10:28 Christoph Heiss
2025-03-26 9:25 ` Christoph Heiss [this message]
2025-03-26 9:39 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D8Q38M7I4N2H.1BUOMI8OBGWXW@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal