Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]

From: "Max Carrara" <m.carrara@proxmox.com>
To: "Roland Kammerer" <roland.kammerer@linbit.com>,
	"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] storage plugins: what is plugindata()->{content}[1]
Date: Wed, 12 Mar 2025 12:09:43 +0100	[thread overview]
Message-ID: <D8E8OZGX1HI7.QH6MQS4GLOTI@proxmox.com> (raw)
In-Reply-To: <Z8qtOTycFZpN5bpL@arm64>

On Fri Mar 7, 2025 at 9:24 AM CET, Roland Kammerer wrote:
> Hi Max,
>
> took me a bit longer than expected, but here we go...
>

Thanks a lot for your detailed feedback, it's highly appreciated!

You'll probably be delighted that a couple of the things you mentioned
are already in progress:

- We're in the process of documenting the PVE::Storage::Plugin API; I'll
  also see if I can address some of your points there already. We can't
  change the API right away of course, so I'd personally rather have
  those "historical" things documented. This will also include what's
  mandatory to implement, what's optional, what you shouldn't override
  at all, etc. Also the specific cases in which you'd probably want to
  implement (or not implement something).

- There's also an example storage plugin we're currently writing, which
  basically does as you suggested. What I have in mind there is that
  we'd show you how to build that specific plugin step-by-step while
  also providing the complete source of the final plugin as well as a
  package so you can just install it and see it in action, too.

API changes of course aren't as easy / straightforward to make, and
there's also the question of whether they'd actually be worth it
overall. But, I've nevertheless noted those things down -- right now the
documentation is a much higher priority, though. At least from my side.

The testing suite you mentioned sounds interesting; I'll add that to my
backlog as well and give it some ponderment. If you have any concrete
ideas regarding this, feel free to toss them my way!

Last but not least, the GUI integration is a very good point. I can't
promise anything in that regard yet, but I'm also taking note here.
Definitely something that can be improved.

Thanks again for your detailed feedback, it's really valuable! If there
are ever any other issues you come across, feel free to let me know here
in this thread. I have taken note of everything you said.

_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel