From: "Christoph Heiss" <c.heiss@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH proxmox-ve-rs] config: fix a few clippy warnings
Date: Tue, 25 Feb 2025 11:25:13 +0100 [thread overview]
Message-ID: <D81GCQLG3ZEO.3DCCHMZRAKYF@proxmox.com> (raw)
In-Reply-To: <20250117075117.195550-1-c.heiss@proxmox.com>
Ping, still applies.
FWIW, no new warnings popped up with 1.85.
On Fri Jan 17, 2025 at 8:51 AM CET, Christoph Heiss wrote:
> .. as newly introduced with 1.84.
>
> Namely `elided_named_lifetimes` for the change of `SdnConfig` and
> `clippy::needless_lifetimes` for the rest.
>
> Signed-off-by: Christoph Heiss <c.heiss@proxmox.com>
> ---
> proxmox-ve-config/src/firewall/parse.rs | 6 +++---
> proxmox-ve-config/src/sdn/config.rs | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/proxmox-ve-config/src/firewall/parse.rs b/proxmox-ve-config/src/firewall/parse.rs
> index 7bf00c0..8cf4757 100644
> --- a/proxmox-ve-config/src/firewall/parse.rs
> +++ b/proxmox-ve-config/src/firewall/parse.rs
> @@ -316,7 +316,7 @@ pub mod serde_option_log_ratelimit {
> #[derive(Clone, Copy, Debug)]
> pub struct SomeStrDeserializer<'a, E>(serde::de::value::StrDeserializer<'a, E>);
>
> -impl<'de, 'a, E> serde::de::Deserializer<'de> for SomeStrDeserializer<'a, E>
> +impl<'de, E> serde::de::Deserializer<'de> for SomeStrDeserializer<'_, E>
> where
> E: serde::de::Error,
> {
> @@ -379,7 +379,7 @@ impl<'a> From<&'a str> for SomeStr<'a> {
> }
> }
>
> -impl<'de, 'a, E> serde::de::IntoDeserializer<'de, E> for SomeStr<'a>
> +impl<'a, E> serde::de::IntoDeserializer<'_, E> for SomeStr<'a>
> where
> E: serde::de::Error,
> {
> @@ -465,7 +465,7 @@ impl From<String> for SomeString {
> }
> }
>
> -impl<'de, E> serde::de::IntoDeserializer<'de, E> for SomeString
> +impl<E> serde::de::IntoDeserializer<'_, E> for SomeString
> where
> E: serde::de::Error,
> {
> diff --git a/proxmox-ve-config/src/sdn/config.rs b/proxmox-ve-config/src/sdn/config.rs
> index 7ee1101..880efc2 100644
> --- a/proxmox-ve-config/src/sdn/config.rs
> +++ b/proxmox-ve-config/src/sdn/config.rs
> @@ -544,7 +544,7 @@ impl SdnConfig {
> pub fn ipsets<'a>(
> &'a self,
> filter: Option<&'a Allowlist<VnetName>>,
> - ) -> impl Iterator<Item = Ipset> + '_ {
> + ) -> impl Iterator<Item = Ipset> + 'a {
> self.zones
> .values()
> .flat_map(|zone| zone.vnets())
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2025-02-25 10:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-17 7:51 Christoph Heiss
2025-02-25 10:25 ` Christoph Heiss [this message]
2025-04-04 7:54 ` [pve-devel] applied: " Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D81GCQLG3ZEO.3DCCHMZRAKYF@proxmox.com \
--to=c.heiss@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Service provided by Proxmox Server Solutions GmbH | Privacy | Legal