[pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Alexander Abraham]

The Flutter frontend of PVE was not compilable for Android
with the versions of different tools set in the project files.
The versions of the tools causing this problem was updated
and the app compiles for Android.

Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
---
 android/app/build.gradle                         | 10 +++++++++-
 android/gradle/wrapper/gradle-wrapper.properties |  2 +-
 android/settings.gradle                          |  4 ++--
 3 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/android/app/build.gradle b/android/app/build.gradle
index 4f827a5..59c318d 100644
--- a/android/app/build.gradle
+++ b/android/app/build.gradle
@@ -45,6 +45,7 @@ def keystoreSecret = System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
 
 android {
     compileSdkVersion 34
+    namespace = "com.proxmox.app.pve_flutter_frontend"
 
     sourceSets {
         main.java.srcDirs += 'src/main/kotlin'
@@ -52,7 +53,7 @@ android {
 
 
     defaultConfig {
-        applicationId "com.proxmox.app.pve_flutter_frontend"
+        applicationId namespace
         minSdkVersion 23
         targetSdkVersion 34
         versionCode flutterVersionCode.toInteger()
@@ -74,9 +75,16 @@ android {
             signingConfig signingConfigs.release
         }
     }
+    compileOptions {
+        sourceCompatibility JavaVersion.VERSION_17
+        targetCompatibility JavaVersion.VERSION_17
+    }
     lint {
         disable 'InvalidPackage'
     }
+    kotlinOptions{
+        jvmTarget = '17'
+    }
 }
 
 flutter {
diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
index 0732d12..90d1364 100644
--- a/android/gradle/wrapper/gradle-wrapper.properties
+++ b/android/gradle/wrapper/gradle-wrapper.properties
@@ -1,6 +1,6 @@
 #Mon Apr 24 14:18:06 CEST 2023
 distributionBase=GRADLE_USER_HOME
 distributionPath=wrapper/dists
-distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
+distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
 zipStoreBase=GRADLE_USER_HOME
 zipStorePath=wrapper/dists
diff --git a/android/settings.gradle b/android/settings.gradle
index 4fc86fd..1da49ad 100644
--- a/android/settings.gradle
+++ b/android/settings.gradle
@@ -18,8 +18,8 @@ pluginManagement {
 
 plugins {
     id "dev.flutter.flutter-plugin-loader" version "1.0.0"
-    id "com.android.application" version "7.4.2" apply false
-    id "org.jetbrains.kotlin.android" version "1.7.20" apply false
+    id "com.android.application" version "8.7.0" apply false
+    id "org.jetbrains.kotlin.android" version "1.8.22" apply false
 }
 
 include ':app'
-- 
2.39.5



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Shannon Sterz]

On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
>
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>  android/app/build.gradle                         | 10 +++++++++-
>  android/gradle/wrapper/gradle-wrapper.properties |  2 +-
>  android/settings.gradle                          |  4 ++--
>  3 files changed, 12 insertions(+), 4 deletions(-)
>
> diff --git a/android/app/build.gradle b/android/app/build.gradle
> index 4f827a5..59c318d 100644
> --- a/android/app/build.gradle
> +++ b/android/app/build.gradle
> @@ -45,6 +45,7 @@ def keystoreSecret = System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
>
>  android {
>      compileSdkVersion 34
> +    namespace = "com.proxmox.app.pve_flutter_frontend"

i haven't tested this, don't have a flutter setup here, but the
inconsistent use of "=" seems strange to me. looking at the android
documentation you are supposed to use either "=" consistently in a
build.gradle.kts file or not in a build.gradle file.

did you mix them intentionally?

[1]: https://developer.android.com/build/gradle-build-overview#kts

>
>      sourceSets {
>          main.java.srcDirs += 'src/main/kotlin'
> @@ -52,7 +53,7 @@ android {
>
>
>      defaultConfig {
> -        applicationId "com.proxmox.app.pve_flutter_frontend"
> +        applicationId namespace
>          minSdkVersion 23
>          targetSdkVersion 34
>          versionCode flutterVersionCode.toInteger()
> @@ -74,9 +75,16 @@ android {
>              signingConfig signingConfigs.release
>          }
>      }
> +    compileOptions {
> +        sourceCompatibility JavaVersion.VERSION_17
> +        targetCompatibility JavaVersion.VERSION_17
> +    }
>      lint {
>          disable 'InvalidPackage'
>      }
> +    kotlinOptions{
> +        jvmTarget = '17'
> +    }
>  }
>
>  flutter {
> diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
> index 0732d12..90d1364 100644
> --- a/android/gradle/wrapper/gradle-wrapper.properties
> +++ b/android/gradle/wrapper/gradle-wrapper.properties
> @@ -1,6 +1,6 @@
>  #Mon Apr 24 14:18:06 CEST 2023
>  distributionBase=GRADLE_USER_HOME
>  distributionPath=wrapper/dists
> -distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
> +distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
>  zipStoreBase=GRADLE_USER_HOME
>  zipStorePath=wrapper/dists
> diff --git a/android/settings.gradle b/android/settings.gradle
> index 4fc86fd..1da49ad 100644
> --- a/android/settings.gradle
> +++ b/android/settings.gradle
> @@ -18,8 +18,8 @@ pluginManagement {
>
>  plugins {
>      id "dev.flutter.flutter-plugin-loader" version "1.0.0"
> -    id "com.android.application" version "7.4.2" apply false
> -    id "org.jetbrains.kotlin.android" version "1.7.20" apply false
> +    id "com.android.application" version "8.7.0" apply false
> +    id "org.jetbrains.kotlin.android" version "1.8.22" apply false
>  }
>
>  include ':app'



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

[pve-devel] applied: [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Thomas Lamprecht]

Am 20.02.25 um 15:37 schrieb Alexander Abraham:
> The Flutter frontend of PVE was not compilable for Android
> with the versions of different tools set in the project files.
> The versions of the tools causing this problem was updated
> and the app compiles for Android.
> 
> Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> ---
>  android/app/build.gradle                         | 10 +++++++++-
>  android/gradle/wrapper/gradle-wrapper.properties |  2 +-
>  android/settings.gradle                          |  4 ++--
>  3 files changed, 12 insertions(+), 4 deletions(-)
> 
>

applied, thanks!

I fixed-up the inconsistent assignment by dropping the `=` for the
namespace property as pointed out by Shannon – I'd encourage you to
replay on such reviews on the mailing list in the future, it's more
than fine to point out that it was just an oversight, or give the
actual reason for doing it this way, if there's any.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Alexander Abraham]

Hi Shannon,

sorry I only just saw this now. (Keeping up with all the emails coming in is something I still need to get on top of.) At the time this was an oversight on my part. Apologies for this. I was trying to get the build working and used a suggestion I saw in an old forum post of someone who was having the same problem. For them, specifying the namespace was the missing piece for getting the build to work.

Best,
Alexander
> Shannon Sterz <s.sterz@proxmox.com> hat am 21.02.2025 15:45 CET geschrieben:
> 
>  
> On Thu Feb 20, 2025 at 3:37 PM CET, Alexander Abraham wrote:
> > The Flutter frontend of PVE was not compilable for Android
> > with the versions of different tools set in the project files.
> > The versions of the tools causing this problem was updated
> > and the app compiles for Android.
> >
> > Signed-off-by: Alexander Abraham <a.abraham@proxmox.com>
> > ---
> >  android/app/build.gradle                         | 10 +++++++++-
> >  android/gradle/wrapper/gradle-wrapper.properties |  2 +-
> >  android/settings.gradle                          |  4 ++--
> >  3 files changed, 12 insertions(+), 4 deletions(-)
> >
> > diff --git a/android/app/build.gradle b/android/app/build.gradle
> > index 4f827a5..59c318d 100644
> > --- a/android/app/build.gradle
> > +++ b/android/app/build.gradle
> > @@ -45,6 +45,7 @@ def keystoreSecret = System.getenv('PROXMOX_APP_KEYSTORE_SECRET')
> >
> >  android {
> >      compileSdkVersion 34
> > +    namespace = "com.proxmox.app.pve_flutter_frontend"
> 
> i haven't tested this, don't have a flutter setup here, but the
> inconsistent use of "=" seems strange to me. looking at the android
> documentation you are supposed to use either "=" consistently in a
> build.gradle.kts file or not in a build.gradle file.
> 
> did you mix them intentionally?
> 
> [1]: https://developer.android.com/build/gradle-build-overview#kts
> 
> >
> >      sourceSets {
> >          main.java.srcDirs += 'src/main/kotlin'
> > @@ -52,7 +53,7 @@ android {
> >
> >
> >      defaultConfig {
> > -        applicationId "com.proxmox.app.pve_flutter_frontend"
> > +        applicationId namespace
> >          minSdkVersion 23
> >          targetSdkVersion 34
> >          versionCode flutterVersionCode.toInteger()
> > @@ -74,9 +75,16 @@ android {
> >              signingConfig signingConfigs.release
> >          }
> >      }
> > +    compileOptions {
> > +        sourceCompatibility JavaVersion.VERSION_17
> > +        targetCompatibility JavaVersion.VERSION_17
> > +    }
> >      lint {
> >          disable 'InvalidPackage'
> >      }
> > +    kotlinOptions{
> > +        jvmTarget = '17'
> > +    }
> >  }
> >
> >  flutter {
> > diff --git a/android/gradle/wrapper/gradle-wrapper.properties b/android/gradle/wrapper/gradle-wrapper.properties
> > index 0732d12..90d1364 100644
> > --- a/android/gradle/wrapper/gradle-wrapper.properties
> > +++ b/android/gradle/wrapper/gradle-wrapper.properties
> > @@ -1,6 +1,6 @@
> >  #Mon Apr 24 14:18:06 CEST 2023
> >  distributionBase=GRADLE_USER_HOME
> >  distributionPath=wrapper/dists
> > -distributionUrl=https\://services.gradle.org/distributions/gradle-7.6.1-bin.zip
> > +distributionUrl=https\://services.gradle.org/distributions/gradle-8.10.2-all.zip
> >  zipStoreBase=GRADLE_USER_HOME
> >  zipStorePath=wrapper/dists
> > diff --git a/android/settings.gradle b/android/settings.gradle
> > index 4fc86fd..1da49ad 100644
> > --- a/android/settings.gradle
> > +++ b/android/settings.gradle
> > @@ -18,8 +18,8 @@ pluginManagement {
> >
> >  plugins {
> >      id "dev.flutter.flutter-plugin-loader" version "1.0.0"
> > -    id "com.android.application" version "7.4.2" apply false
> > -    id "org.jetbrains.kotlin.android" version "1.7.20" apply false
> > +    id "com.android.application" version "8.7.0" apply false
> > +    id "org.jetbrains.kotlin.android" version "1.8.22" apply false
> >  }
> >
> >  include ':app'


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Thomas Lamprecht]

Am 03.03.25 um 10:38 schrieb Alexander Abraham:
> Keeping up with all the emails coming in is something I still need to get on top of.

I'd recommend setting up mail filter to move all mails that stem from a mailing list,
i.e. have the List-Id header set, to a dedicated folder for that list. Most filter
solution, including our company mail here, have dedicated criteria to match list mails.
Fir pve-devel you would use then e.g. the following value to match on:
"Proxmox VE development discussion <pve-devel.lists.proxmox.com>"


That the list mails go into a separate folder leaving your inbox less cluttered and
giving more attention to mails where you are explicitly in the "To" or "Cc" list, as
such mails are directly delivered (not through the list) and thus won't match such a
mailing-list filter, ensuring you will get them in your (now less crowded) inbox.


> For them, specifying the namespace was the missing piece for getting the build to work.

That itself is fine, Shannon just wondered why you use an assignment like `namespace = "..."`
here over the `namespace "..."` (note the missing `=`). As the former is for gradle build
scripts in the kotlin script (kts) language, a newer variant to configure gradle builds,
whereas the latter variant without the equal sign is for the older gradle native groovy
language that we currently use here.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel

Re: [pve-devel] [PATCH pve_flutter_frontend] Updated Gradle version and some build dependencies.

[Alexander Abraham]

Hi,

thank you for explaining this to me. I will make sure I set this up.

I did read the link that Shannon sent and of course, understood the difference upon reading it. I wasn't quite sure which to use as the poster used the kts variety and we are using the Groovy variety. Now I know and I'm clear about which is for which.

Best,
Alexander


> Thomas Lamprecht <t.lamprecht@proxmox.com> hat am 03.03.2025 10:50 CET geschrieben:
> 
>  
> Am 03.03.25 um 10:38 schrieb Alexander Abraham:
> > Keeping up with all the emails coming in is something I still need to get on top of.
> 
> I'd recommend setting up mail filter to move all mails that stem from a mailing list,
> i.e. have the List-Id header set, to a dedicated folder for that list. Most filter
> solution, including our company mail here, have dedicated criteria to match list mails.
> Fir pve-devel you would use then e.g. the following value to match on:
> "Proxmox VE development discussion <pve-devel.lists.proxmox.com>"
> 
> 
> That the list mails go into a separate folder leaving your inbox less cluttered and
> giving more attention to mails where you are explicitly in the "To" or "Cc" list, as
> such mails are directly delivered (not through the list) and thus won't match such a
> mailing-list filter, ensuring you will get them in your (now less crowded) inbox.
> 
> 
> > For them, specifying the namespace was the missing piece for getting the build to work.
> 
> That itself is fine, Shannon just wondered why you use an assignment like `namespace = "..."`
> here over the `namespace "..."` (note the missing `=`). As the former is for gradle build
> scripts in the kotlin script (kts) language, a newer variant to configure gradle builds,
> whereas the latter variant without the equal sign is for the older gradle native groovy
> language that we currently use here.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel