Re: [pve-devel] [RFC PATCH installer] fix #5973: auto: first boot: allow snake- and kebabcased property names

["Christoph Heiss" <c.heiss@proxmox.com>]

On Tue Jan 28, 2025 at 3:38 PM CET, Thomas Lamprecht wrote:
> Am 05.12.24 um 15:07 schrieb Daniel Kral:
[..]
> > - with `cert-fingerprint` (which works correctly as expected), and
> > - with `cert_fingerprint` (which will fail at a parser error with the
> > newest Proxmox VE 8.3-1 ISO).
>
> This is a bit worded like that behavior would be a regression, but it
> isn't AFAICT as this was always kebab-case from when being added in
> commit 6526662 ("fix #5579: auto-installer: add optional first-boot hook
> script"); or am I overlooking something?

To provide context; since I actually introduced this option/code: That
was indeed intentionally kebab-cased, as we prefer that style for new
code - as explained below.

[..]
> > -#[serde(rename_all = "kebab-case", deny_unknown_fields)]
> > +#[serde(deny_unknown_fields)]
>
> But we prefer kebab-case for any public API/CLI parameter for modern code;
> so shouldn't we rather to the opposite, transform all other (de)serializable
> configs to use kebab-case with backward-compat aliases for the cases it
> matters?

I'd prefer that variant too, FWIW.


_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel