From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Thomas Lamprecht" <t.lamprecht@proxmox.com>,
"Proxmox VE development discussion" <pve-devel@lists.proxmox.com>,
"Lukas Wagner" <l.wagner@proxmox.com>
Subject: Re: [pve-devel] applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys
Date: Tue, 26 Nov 2024 10:27:51 +0100 [thread overview]
Message-ID: <D5W058GWP0AN.IGIBK9HFVYQP@proxmox.com> (raw)
In-Reply-To: <0c825d39-69cc-49ce-a078-647818f6cc5a@proxmox.com>
On Mon Nov 25, 2024 at 11:19 PM CET, Thomas Lamprecht wrote:
> Am 25.11.24 um 11:22 schrieb Lukas Wagner:
>> Ping for patches 3-6, these were never applied.
>> They do not add any functional changes, but only aim to improve
>> code style and add some tests.
>>
>
>
> I applied them now, thanks!
>
> btw. I totally forgot to mention today that Shannon might need these sendmail
> stuff too for the internal tooling she works on, so maybe making this public,
> or moving it to a micro-crate could indeed be worth it.
> Copying such small stuff more than once is most of the time a good signal that
> it might be nonetheless good to share it; but no hard feelings either way from
> my side, I just wanted to note that use case before I forget it.
actually i needed to adapt this to add support for attachments, which
require reworking the multipart logic a bit too. i can factor that out
into it's own `proxmox-sendmail` crate or similar and make
`proxmox-notify`'s sendmail endpoint use that too. if that's desired, i
can send patches for that too.
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-11-26 9:28 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-24 12:31 [pve-devel] " Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 2/6] sys: mark email fn's as deprecated Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 3/6] notify: sendmail: make mailfrom and author non-optional Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 4/6] notify: move mail formatting to separate function Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 5/6] notify: sendmail: always send multi-part message Lukas Wagner
2024-06-24 12:31 ` [pve-devel] [PATCH proxmox 6/6] notify: sendmail: code style improvements Lukas Wagner
2024-07-12 8:56 ` [pve-devel] partially-applied: [PATCH proxmox 1/6] notify: copy sendmail/forward fn's from proxmox_sys Wolfgang Bumiller
2024-11-25 10:22 ` [pve-devel] " Lukas Wagner
2024-11-25 22:19 ` [pve-devel] applied: " Thomas Lamprecht
2024-11-26 9:27 ` Shannon Sterz [this message]
2024-11-26 10:21 ` Thomas Lamprecht
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5W058GWP0AN.IGIBK9HFVYQP@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=l.wagner@proxmox.com \
--cc=pve-devel@lists.proxmox.com \
--cc=t.lamprecht@proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox