From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Proxmox VE development discussion" <pve-devel@lists.proxmox.com>
Cc: "pve-devel" <pve-devel-bounces@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH] webhook edit: do not split translatable strings
Date: Thu, 21 Nov 2024 15:47:32 +0100 [thread overview]
Message-ID: <D5RXTA3OPIVP.DFCWVRI9IYW8@proxmox.com> (raw)
In-Reply-To: <20241121142809.332913-1-m.sandoval@proxmox.com>
On Thu Nov 21, 2024 at 3:28 PM CET, Maximiliano Sandoval wrote:
> Splitting translatable strings deprives translators for context which
> might be needed for getting the correct tenses or genders. See [1] for
> example.
>
> [1] https://wiki.gnome.org/TranslationProject(2f)DevGuidelines(2f)Never(20)split(20)sentences.html
>
> Signed-off-by: Maximiliano Sandoval <m.sandoval@proxmox.com>
> ---
> src/panel/WebhookEditPanel.js | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/src/panel/WebhookEditPanel.js b/src/panel/WebhookEditPanel.js
> index ca99333..9a7b222 100644
> --- a/src/panel/WebhookEditPanel.js
> +++ b/src/panel/WebhookEditPanel.js
> @@ -70,7 +70,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', {
> xtype: 'pmxWebhookKeyValueList',
> name: 'header',
> fieldLabel: gettext('Headers'),
> - subject: gettext('Header'),
> + addLabel: gettext('Add Header'),
> maskValues: false,
> cbind: {
> isCreate: '{isCreate}',
> @@ -92,7 +92,7 @@ Ext.define('Proxmox.panel.WebhookEditPanel', {
> xtype: 'pmxWebhookKeyValueList',
> name: 'secret',
> fieldLabel: gettext('Secrets'),
> - subject: gettext('Secret'),
> + addLabel: gettext('Add Secret'),
> maskValues: true,
> cbind: {
> isCreate: '{isCreate}',
> @@ -170,8 +170,8 @@ Ext.define('Proxmox.form.WebhookKeyValueList', {
> // override for column header
> fieldTitle: gettext('Item'),
>
> - // the text for a single element, used for the add button
> - subject: undefined,
> + // label displayed in the "Add" button
> + addLabel: undefined,
>
> // will be applied to the textfields
> maskRe: undefined,
> @@ -403,7 +403,7 @@ Ext.define('Proxmox.form.WebhookKeyValueList', {
> },
> {
> xtype: 'button',
> - text: me.subject ? Ext.String.format(gettext('Add {0}'), me.subject) : gettext('Add'),
> + text: me.addLabel ? me.addLabel : gettext('Add'),
wouldn't it be more elegant to simply define `addLabel` as
`gettext('Add')` and then override that where needed? that would safe
this akward ternary operator. haven't tested that though.
> iconCls: 'fa fa-plus-circle',
> handler: 'addLine',
> },
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
prev parent reply other threads:[~2024-11-21 14:47 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 14:28 Maximiliano Sandoval
2024-11-21 14:47 ` Shannon Sterz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D5RXTA3OPIVP.DFCWVRI9IYW8@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=pve-devel-bounces@lists.proxmox.com \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox