Re: [pve-devel] partially-applied-series: [PATCH v3 pve-common 0/5] Section Config: Documentation & Code Cleanup

["Max Carrara" <m.carrara@proxmox.com>]

On Mon Nov 11, 2024 at 2:59 PM CET, Thomas Lamprecht wrote:
> Am 31.10.24 um 18:07 schrieb Max Carrara:
> > Section Config: Documentation & Code Cleanup - v3
> > =================================================
> > 
> > Notable Changes Since v2
> > ------------------------
> > 
> >   * Adapt documentation syntax and style
> >   * Use less emphasis codes `I<>`
> >   * Add commit to fix spelling
> > 
> > Please see the comments in the individual patches for a detailed list of
> > changes.
> > 
> > Older Versions
> > --------------
> > 
> > v2: https://lore.proxmox.com/pve-devel/20240702141314.445130-1-m.carrara@proxmox.com/
> > v1: https://lore.proxmox.com/pve-devel/20240604092850.126083-1-m.carrara@proxmox.com/
> > 
> > Summary of Changes
> > ------------------
> > 
> > Max Carrara (5):
> >   section config: document package and its methods with POD
> >   section config: update code style
> >   section config: clean up parser logic and semantics
>
> ^- skipped this one for now.
>
> >   section config: make subroutine `delete_from_config` private
> >   section config: fix spelling of variable
> > 
> >  src/PVE/SectionConfig.pm | 1197 ++++++++++++++++++++++++++++++++------
> >  1 file changed, 1008 insertions(+), 189 deletions(-)
> > 
>
> After talking with Stefan Hanreich off-list he mentioned that this series was
> helpfull to some recent section-config related work of his, so partially applied
> this series, thanks!

Thanks a bunch!

Regarding the commit that was left out: I'll see if I can send this in
as part of a separate series that perhaps also clears some other stuff
up and adds some tests, since I'm in refactor-land at the moment anyway.



_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel