From: "Shannon Sterz" <s.sterz@proxmox.com>
To: "Jing Luo" <jing@jing.rocks>, <pve-devel@lists.proxmox.com>
Subject: Re: [pve-devel] [PATCH pve-qemu-kvm] patch: pbs block driver: correct a data type
Date: Mon, 10 Jun 2024 10:53:13 +0200 [thread overview]
Message-ID: <D1W7KNJ9V1T1.303UEP9076GBV@proxmox.com> (raw)
In-Reply-To: <20240607094734.3883693-1-jing@jing.rocks>
On Fri Jun 7, 2024 at 11:43 AM CEST, Jing Luo wrote:
> gcc warns (-Werror=type-limits) that it will always be false for the
> if statement. This is because here s->aid is defined as char, while
> proxmox_restore_open_image() returns an int. Change the type to int.
> Strangely gcc warns it on arm64 build but not amd64 build...
probably because char is unsigned on arm architectures (usually), but
signed on x86 [1]:
> Although the ARM architecture has the LDRSB instruction, that loads a
> signed byte into a 32-bit register with sign extension, the earliest
> versions of the architecture did not. It made sense at the time for
> the compiler to treat simple chars as unsigned, whereas on the x86
> simple chars are, by default, treated as signed.
[1]: https://developer.arm.com/documentation/den0013/d/Porting/Miscellaneous-C-porting-issues/unsigned-char-and-signed-char
>
> Signed-off-by: Jing Luo <jing@jing.rocks>
> ---
> ...2-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
> index b9578ba..9e68167 100644
> --- a/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
> +++ b/debian/patches/pve/0032-PVE-Add-PBS-block-driver-to-map-backup-archives-into.patch
> @@ -68,7 +68,7 @@ index 0000000000..dd72356bd3
> +
> +typedef struct {
> + ProxmoxRestoreHandle *conn;
> -+ char aid;
> ++ int aid;
> + int64_t length;
> +
> + char *repository;
_______________________________________________
pve-devel mailing list
pve-devel@lists.proxmox.com
https://lists.proxmox.com/cgi-bin/mailman/listinfo/pve-devel
next prev parent reply other threads:[~2024-06-10 8:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20240607094734.3883693-1-jing@jing.rocks>
2024-06-07 11:49 ` Fiona Ebner
2024-06-10 1:48 ` Jing Luo via pve-devel
[not found] ` <57a95560b7c8bce55d2e8270d18d9778@jing.rocks>
2024-06-10 9:27 ` Fiona Ebner
2024-06-10 12:05 ` [pve-devel] [PATCH v2 pve-qemu-kvm] patches: " Jing Luo via pve-devel
[not found] ` <20240610122909.1216178-2-jing@jing.rocks>
2024-06-10 14:12 ` [pve-devel] applied: " Fiona Ebner
2024-06-10 8:53 ` Shannon Sterz [this message]
2024-06-07 9:43 [pve-devel] [PATCH pve-qemu-kvm] patch: " Jing Luo via pve-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=D1W7KNJ9V1T1.303UEP9076GBV@proxmox.com \
--to=s.sterz@proxmox.com \
--cc=jing@jing.rocks \
--cc=pve-devel@lists.proxmox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox